Compare commits

..

6 Commits

Author SHA1 Message Date
Adam Meehan
3269312ae2 v4.1.1 2019-08-06 15:12:47 +10:00
Adam Meehan
d9b81b79a4 bump README install version 2019-08-06 15:07:30 +10:00
Adam Meehan
8a85da19e2 removing ruby 2.3 and rails 4.0 and 4.1 official support 2019-08-06 15:04:17 +10:00
Adam Meehan
f2cd9aca17 ensure timeliness initializer is after initializer files 2019-08-03 12:53:04 +10:00
Adam Meehan
5354f603ff fix sqlite3 version 2019-08-03 12:52:30 +10:00
Adam Meehan
6193410b55 Add Rails initializer to set Timeliness.ambiguous_date_format for Timeliness v0.4+ 2019-08-03 12:39:18 +10:00
10 changed files with 44 additions and 38 deletions

View File

@@ -9,12 +9,6 @@ bundler_args: --verbose
matrix:
include:
- rvm: "2.3.7"
gemfile: gemfiles/rails_4_0.gemfile
- rvm: "2.3.7"
gemfile: gemfiles/rails_4_1.gemfile
- rvm: "2.3.7"
gemfile: gemfiles/rails_4_2.gemfile
- rvm: "2.4.6"
gemfile: gemfiles/rails_4_2.gemfile
- rvm: "2.5.5"

View File

@@ -1,3 +1,10 @@
= 4.1.1 [2019-08-06]
* Add initializer to ensure Timeliness default ambigiuous date handling config
in Timeliness v0.4.1+ is set correctly when using `use_us_formats` or
`use_euro_formats` switcher to set default.
* Removed build support for Ruby 2.3 and Rails 4.0 and 4.1 to EOL official
support for those.
= 4.1.0 [2019-06-11]
* Relaxed Timeliness dependency version to >= 0.3.10 and < 1, which allows
version 0.4 with threadsafety fix for use_us_formats and use_euro_formats

View File

@@ -9,5 +9,5 @@ gem 'rspec-rails', '~> 3.7'
gem 'timecop'
gem 'byebug'
gem 'appraisal'
gem 'sqlite3'
gem 'sqlite3', '~> 1.3.13'
gem 'nokogiri', '~> 1.8'

View File

@@ -5,7 +5,8 @@
== Description
Complete validation of dates, times and datetimes for Rails 4.x and ActiveModel.
Complete validation of dates, times and datetimes for Rails 4.2.x and ActiveModel. Rails 4.0.x and 4.1.x may
still work but official support has ended.
If you a looking for the old version for Rails 3.x go here[http://github.com/adzap/validates_timeliness/tree/v3.x].
@@ -30,7 +31,7 @@ If you a looking for the old version for Rails 3.x go here[http://github.com/adz
== Installation
# in Gemfile
gem 'validates_timeliness', '~> 4.0'
gem 'validates_timeliness', '~> 4.1'
# Run bundler
$ bundle install

View File

@@ -1,14 +0,0 @@
# This file was generated by Appraisal
source "https://rubygems.org"
gem "rails", "~> 4.0.13"
gem "rspec", "~> 3.6.0"
gem "rspec-rails", "~> 3.6.0"
gem "timecop"
gem "byebug"
gem "appraisal"
gem "sqlite3", "~> 1.3.0"
gem "nokogiri", "1.6.7"
gemspec path: "../"

View File

@@ -1,14 +0,0 @@
# This file was generated by Appraisal
source "https://rubygems.org"
gem "rails", "~> 4.1.14"
gem "rspec", "~> 3.6.0"
gem "rspec-rails", "~> 3.6.0"
gem "timecop"
gem "byebug"
gem "appraisal"
gem "sqlite3", "~> 1.3.0"
gem "nokogiri", "1.6.7"
gemspec path: "../"

View File

@@ -11,5 +11,13 @@ module ValidatesTimeliness
initializer "validates_timeliness.initialize_restriction_errors" do
ValidatesTimeliness.ignore_restriction_errors = !Rails.env.test?
end
initializer "validates_timeliness.initialize_timeliness_ambiguous_date_format", :after => 'load_config_initializers' do
if Timeliness.respond_to?(:ambiguous_date_format) # i.e. v0.4+
# Set default for each new thread if you have changed the default using
# the format switching methods.
Timeliness.configuration.ambiguous_date_format = Timeliness::Definitions.current_date_format
end
end
end
end

View File

@@ -1,3 +1,3 @@
module ValidatesTimeliness
VERSION = '4.1.0'
VERSION = '4.1.1'
end

View File

@@ -9,6 +9,8 @@ require 'timecop'
require 'validates_timeliness'
require 'validates_timeliness/orm/active_model'
require 'rails/railtie'
require 'support/test_model'
require 'support/model_helpers'
require 'support/config_helper'

View File

@@ -0,0 +1,22 @@
require 'validates_timeliness/railtie'
RSpec.describe ValidatesTimeliness::Railtie do
context "intializers" do
context "validates_timeliness.initialize_timeliness_ambiguous_date_format" do
it 'should set the timeliness default ambiguous date format from the current format' do
expect(Timeliness.configuration.ambiguous_date_format).to eq :us
ValidatesTimeliness.parser.use_euro_formats
initializer("validates_timeliness.initialize_timeliness_ambiguous_date_format").run
expect(Timeliness.configuration.ambiguous_date_format).to eq :euro
end
end if Timeliness.respond_to?(:ambiguous_date_format)
def initializer(name)
ValidatesTimeliness::Railtie.initializers.find { |i|
i.name == name
} || raise("Initializer #{name} not found")
end
end
end