ditkrg/active_model_serializers
4
0
Fork 0
mirror of https://github.com/ditkrg/active_model_serializers.git synced 2026-01-23 06:16:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused/unusable unsubscribe since we don't want to unsubscribe

Browse Source 
In 0.9 (which this implementation is based on), the instrumentation
was `!serialize.active_model_serializers`.

https://github.com/rails-api/active_model_serializers/pull/596/

The '!' in the event name meant the event wasn't meant for
production.

https://github.com/rails/rails/pull/10446/files#r4075679

Since we intend the event for production and have a log subscriber,
if we unsubscribe from `render.active_model_serializers`, we'll
break other tests that are relying on that event being subscribed.
This commit is contained in:
Benjamin Fleischer 2015-12-22 22:49:42 -06:00
parent ef09c9043f
commit f59431439d
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/active_model_serializers/test/serializer.rb
View File

@ -69,10 +69,6 @@ module ActiveModelSerializers
end end
end end
def unsubscribe
ActiveSupport::Notifications.unsubscribe(event_name)
end
private private
def matches_class? def matches_class?