From f59431439d1bf2b389f3869fb3117d4d9b45e6fc Mon Sep 17 00:00:00 2001 From: Benjamin Fleischer Date: Tue, 22 Dec 2015 22:49:42 -0600 Subject: [PATCH] Remove unused/unusable unsubscribe since we don't want to unsubscribe In 0.9 (which this implementation is based on), the instrumentation was `!serialize.active_model_serializers`. https://github.com/rails-api/active_model_serializers/pull/596/ The '!' in the event name meant the event wasn't meant for production. https://github.com/rails/rails/pull/10446/files#r4075679 Since we intend the event for production and have a log subscriber, if we unsubscribe from `render.active_model_serializers`, we'll break other tests that are relying on that event being subscribed. --- lib/active_model_serializers/test/serializer.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/active_model_serializers/test/serializer.rb b/lib/active_model_serializers/test/serializer.rb index a122d31d..5e1b826b 100644 --- a/lib/active_model_serializers/test/serializer.rb +++ b/lib/active_model_serializers/test/serializer.rb @@ -69,10 +69,6 @@ module ActiveModelSerializers end end - def unsubscribe - ActiveSupport::Notifications.unsubscribe(event_name) - end - private def matches_class?