v3.0.8

Remove deprecated InstanceMethods module when using AS::Concern

CHANGELOG.rdoc

@@ -1,3 +1,7 @@
+= 3.0.8 [2011-12-24]
+* Remove deprecated InstanceMethods module when using AS::Concern
+* Update Mongoid shim for v2.3 compatability.
+
 = 3.0.7 [2011-09-21]
 * Fix ActiveRecord before_type_cast extension for non-dirty attributes.
 * Don't override AR before_type_cast for >= 3.1.0 which now has it's own implementation for date/time attributes.

Gemfile

@@ -11,7 +11,7 @@ gem 'ruby-debug', :platforms => [:ruby_18, :jruby]
 gem 'ruby-debug19', :platforms => [:ruby_19]
 
 group :mongoid do
-  gem 'mongoid', '2.2.0'
+  gem 'mongoid', '~> 2.3.0'
   gem 'bson_ext'
   gem 'system_timer', :platforms => [:ruby_18]
 end

lib/validates_timeliness/attribute_methods.rb

@@ -65,7 +65,6 @@ module ValidatesTimeliness
       end
     end
 
-    module InstanceMethods
     def _timeliness_raw_value_for(attr_name)
       @timeliness_cache && @timeliness_cache[attr_name.to_s]
     end
@@ -74,6 +73,4 @@ module ValidatesTimeliness
       @timeliness_cache = {}
     end
   end
-
-  end
 end

lib/validates_timeliness/extensions/date_time_select.rb

@@ -33,7 +33,6 @@ module ValidatesTimeliness
         end
       end
 
-      module InstanceMethods
       def datetime_selector_with_timeliness(*args)
         @timeliness_date_or_time_tag = true
         datetime_selector_without_timeliness(*args)
@@ -58,7 +57,5 @@ module ValidatesTimeliness
         TimelinessDateTime.new(*values)
       end
     end
-
-    end
   end
 end

lib/validates_timeliness/orm/active_record.rb

@@ -30,14 +30,11 @@ module ValidatesTimeliness
         end
       end
 
-      module InstanceMethods
       def reload(*args)
         _clear_timeliness_cache
         super
       end
     end
-
-    end
   end
 end
 

lib/validates_timeliness/orm/mongoid.rb

@@ -31,6 +31,10 @@ module ValidatesTimeliness
         end
       end
 
+      def reload
+        _clear_timeliness_cache
+        super
+      end
     end
   end
 end
@@ -39,9 +43,12 @@ module Mongoid::Document
   include ValidatesTimeliness::AttributeMethods
   include ValidatesTimeliness::ORM::Mongoid
 
+  # Pre-2.3 reload
+  if instance_methods.include?('reload')
     def reload_with_timeliness
       _clear_timeliness_cache
       reload_without_timeliness
     end
     alias_method_chain :reload, :timeliness
+  end
 end

lib/validates_timeliness/version.rb

@@ -1,3 +1,3 @@
 module ValidatesTimeliness
-  VERSION = '3.0.7'
+  VERSION = '3.0.8'
 end

spec/validates_timeliness/orm/mongoid_spec.rb

@@ -69,22 +69,22 @@ describe ValidatesTimeliness, 'Mongoid' do
       end
 
       context "for a date column" do
-        it 'should store a Time value after parsing string' do
+        it 'should store a Date value after parsing string' do
           r = Article.new
           r.publish_date = '2010-01-01'
 
-          r.publish_date.should be_kind_of(Time)
+          r.publish_date.should be_kind_of(Date)
           r.publish_date.should == Date.new(2010, 1, 1)
         end
       end
 
       context "for a datetime column" do
-        it 'should parse string into Time value' do
+        it 'should parse string into DateTime value' do
           r = Article.new
           r.publish_datetime = '2010-01-01 12:00'
 
-          r.publish_datetime.should be_kind_of(Time)
-          r.publish_datetime.should == Time.utc(2010,1,1,12,0)
+          r.publish_datetime.should be_kind_of(DateTime)
+          r.publish_datetime.should == DateTime.new(2010,1,1,12,0)
         end
       end
     end
@@ -108,6 +108,6 @@ end
 
 rescue LoadError
   puts "Mongoid specs skipped. Mongoid not installed"
-rescue StandardError
-  puts "Mongoid specs skipped. MongoDB connection failed."
+rescue StandardError => e
+  puts "Mongoid specs skipped. MongoDB connection failed with error: #{e.message}"
 end

validates_timeliness.gemspec

@@ -16,5 +16,5 @@ Gem::Specification.new do |s|
   s.test_files       = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.extra_rdoc_files = ["README.rdoc", "CHANGELOG.rdoc", "LICENSE"]
 
-  s.add_runtime_dependency(%q<timeliness>, ["~> 0.3.3"])
+  s.add_runtime_dependency(%q<timeliness>, ["~> 0.3.4"])
 end