Commit Graph

153 Commits

Author SHA1 Message Date
Adam Meehan
bb830baea2 Rails 4.0 and 4.1 compat for #setup method removal 2015-11-10 17:52:34 +11:00
Julien Vanier
7d37882327 Generate attribute methods once instead of on each object creation
This is a memory and performance improvement change.

The attribute methods for timeliness are generated at each object creation instead of once, at first creation like AR attribute methods. Since creating those methods uses `module_eval` it's quite slow when it's done each `Model.new`.

For more details on the performance improvement, see the same change on John Carney's fork: https://github.com/johncarney/validates_timeliness/pull/6
2015-09-24 14:58:12 -04:00
Adam Meehan
12f6d2a467 Merge pull request #104 from johnnyshields/mongoid-3
Update to Mongoid 3
2015-09-12 17:23:20 +10:00
Obfuscoder
f1b8925a36 Fix typo in comment of initializer template 2014-11-02 20:59:50 +01:00
Johnny Shields
99ae8fe7d7 Update for Mongoid 3:
- Now requires Mongoid 3.0 as minimum version (this is the only version to support Rails 3.2)
- Upgrade specs/helpers for Mongoid 3
- Support Mongoid aliased field names (e.g. field :foo, as: bar, type: String). Includes spec
- Support before_type_cast on Mongoid. No code change was required for this, only a spec change.
- There was one mongoid spec that was previously marked pending. I've found that it now works on Mongoid 3.
- Removed some Mongoid 2.3 and earlier hacks, which simplifies the Mongoid ORM code.
2013-07-24 11:05:01 +09:00
Adam Meehan
3d798697e1 Merge pull request #98 from 907th/master
Range with excluded end passed to :between option should be split into :on_or_after and :before options
2013-04-30 04:45:54 -07:00
Alexey Chernenkov
dc0fdc0340 Range with excluded end passed to :between option should be split into :on_or_after and :before options 2013-04-30 15:37:44 +06:00
Will O'Brien
609fafe7bb Require 'active_model'
Apparently classes are lazily required when using autoload. Prompted by
'uninitialized constant ActiveModel::Validations'
2013-04-25 22:42:28 -04:00
Adam Meehan
5becd7886b Removing silly class variables from config module 2012-09-14 18:44:35 +10:00
Adam Meehan
a1dfbf5d7d v3.0.14 2012-08-23 18:40:47 +10:00
Adam Meehan
02fbdc6028 Fix for validates :timeliness form to add attributes to plugin set 2012-08-23 18:38:33 +10:00
Adam Meehan
8c698be4c4 v3.0.13 2012-08-21 10:56:46 +10:00
Adam Meehan
973bbfa82c Moving back to plugin cache for ActiveRecord
This simplifies the code a lot and fixes the issues with date and time
colummns when using the plugin parser.

Add appraisals for all rails 3 versions
2012-08-19 22:57:19 +10:00
Adam Meehan
62557e7e04 Allow any validated attribute to pass timezone aware check in AR 2012-08-09 12:53:29 +10:00
Adam Meehan
8898b8686c v3.0.12 2012-06-23 19:06:38 +10:00
Adam Meehan
aad2db8662 Remove unused cargo culted generator method 2012-06-23 18:58:33 +10:00
Adam Meehan
8e08cbf6e4 Fix load order issue for AR extension using Railite 2012-06-23 18:58:01 +10:00
Adam Meehan
8dd607975b v3.0.11 2012-04-01 16:48:53 +10:00
Adam Meehan
b6acda539f v3.0.10 2012-03-29 13:45:40 +11:00
Adam Meehan
4aa20bb002 Stricter method signature for _timeliness_raw_value_for to take string
Add basic validation specs to each ORM shim
2012-03-29 13:00:28 +11:00
Adam Meehan
df12d6dad0 v3.0.9 2012-03-26 22:00:12 +11:00
Adam Meehan
f11255a7a3 Fix multiparameter extension to not allow partial dates as per ActiveRecord implementation. 2012-03-26 20:22:09 +11:00
Adam Meehan
a6a3dff4d4 Revert "Move AR railtie hook outside of initializer to avoid late inclusion of shim"
This reverts commit 48fd72ae5b.
2012-02-24 11:52:58 +11:00
Adam Meehan
ff594d5873 Tighten up mongoid shim for reload override in 1.8.x and 1.9.x 2012-02-06 22:48:29 +11:00
Adam Meehan
8c1ba048df Refactor timeliness method definition 2012-02-06 22:47:08 +11:00
Adam Meehan
48fd72ae5b Move AR railtie hook outside of initializer to avoid late inclusion of shim 2012-02-06 22:45:01 +11:00
Adam Meehan
43f49076fb Changed multiparameter implementation to be more like AR 3.1 but backwards compatible
Specs improved to not make direct call to multiparameter method.
2012-02-02 09:00:14 +11:00
Chris Griego
64a7440de4 Fix multiparameter extension to work with ActiveRecord 3.1 2012-02-02 08:54:39 +11:00
Chris Griego
2702ec3266 The ActiveRecord extension now returns the original return value for .define_attribute_methods
This helps other extensions, like PermalinkFu, which depend on the return value
2012-02-02 08:44:22 +11:00
Adam Meehan
84316bc73a Refactor AR shim for v3.1 checks 2012-02-01 21:24:38 +11:00
Adam Meehan
5be45b00db Hook into undefine_attributes_methods to remove timeliness methods as well 2012-02-01 20:38:05 +11:00
Adam Meehan
f8aeeca0a9 A fix for ActiveRecord 3.1.x and plugin parser not working together (issue #52) 2012-01-26 22:44:01 +11:00
Adam Meehan
acd10f7b64 v3.0.8 2011-12-24 17:50:22 +11:00
Carlos Antonio da Silva
7a784a6c54 Remove InstanceMethods module when using AS::Concern, as it was deprecated in 3.2 2011-12-20 20:52:33 -02:00
Adam Meehan
907fd3e439 Fix for Mongoid shim for reload which was nicely moved into a module to allow super 2011-12-10 17:46:35 +11:00
Adam Meehan
e44e9d2f11 v3.0.7 2011-09-21 21:41:01 +10:00
Adam Meehan
86b7bc4829 Fix before_type_cast for non-dirty attributes (issue #52).
Only use before_type_cast implementation if earlier than 3.1.0 which has
it's own working version for date/time fields now.
2011-09-21 21:28:53 +10:00
Adam Meehan
11ae94cba6 Cleanup DateTimeSelect extension specs 2011-09-18 18:53:38 +10:00
Adam Meehan
473da0fa5e Fix DateTimeSelect extension for Rails 3.1.0 2011-09-18 18:37:01 +10:00
Adam Meehan
e7b503ae4f Fix DateTimeSelect extension to use integers from param values.
Change extension spec to use string params.
2011-09-18 18:34:23 +10:00
Adam Meehan
9a99c47323 Can use simple Mongoid inclusion now that fixed Concern usage is released (a while ago) 2011-09-18 18:33:29 +10:00
Thilo Rusche
ac90ab96cd fixed integer vs string expectation 2011-05-13 17:47:59 +01:00
Thilo Rusche
b4c1a39343 added support for :discard_day in form helpers 2011-05-13 17:13:11 +01:00
Adam Meehan
7886132114 version 3.0.5 2011-05-09 17:34:09 +10:00
Adam Meehan
ac98978441 Better timeliness_type_cast_code 2011-05-09 07:43:41 +10:00
Adam Meehan
ea7c9ec7be Type caste to Date for date columns in AR after parsing string in attribute writer 2011-04-27 07:37:26 +10:00
Adam Meehan
e3dea5aebd use activemodel scoped class name in helper method to remove need for .kind override 2011-02-24 21:12:49 +11:00
Adam Meehan
2822e368e3 Exit restriction validation on first restriction error 2011-02-24 07:58:48 +11:00
Adam Meehan
dac62060df version 3.0.5 2011-01-29 17:42:42 +11:00
Adam Meehan
3793ef2ed4 fix for validation nil value with :format option plugin parser disabled (issue 34) 2011-01-29 16:07:56 +11:00