ditkrg/validates_timeliness
4
0
Fork 0
mirror of https://github.com/ditkrg/validates_timeliness.git synced 2026-01-22 22:06:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor timeliness method definition

Browse Source
This commit is contained in:
Adam Meehan 2012-02-06 22:47:08 +11:00
parent 48fd72ae5b
commit 8c1ba048df
2 changed files with 24 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/validates_timeliness/attribute_methods.rb
View File

@ -30,10 +30,14 @@ module ValidatesTimeliness
def define_timeliness_methods(before_type_cast=false) def define_timeliness_methods(before_type_cast=false)
return if timeliness_validated_attributes.blank? return if timeliness_validated_attributes.blank?
timeliness_validated_attributes.each do |attr_name| timeliness_validated_attributes.each do |attr_name|
define_attribute_timeliness_methods(attr_name, before_type_cast)
end
end
def define_attribute_timeliness_methods(attr_name, before_type_cast=false)
define_timeliness_write_method(attr_name) define_timeliness_write_method(attr_name)
define_timeliness_before_type_cast_method(attr_name) if before_type_cast define_timeliness_before_type_cast_method(attr_name) if before_type_cast
end end
end
def define_timeliness_write_method(attr_name) def define_timeliness_write_method(attr_name)
method_body, line = <<-EOV, __LINE__ + 1 method_body, line = <<-EOV, __LINE__ + 1

26
lib/validates_timeliness/orm/active_record.rb
View File

@ -17,6 +17,17 @@ module ValidatesTimeliness
end end
module ClassMethods module ClassMethods
public
def timeliness_attribute_timezone_aware?(attr_name)
attr_name = attr_name.to_s
create_time_zone_conversion_attribute?(attr_name, columns_hash[attr_name])
end
def timeliness_attribute_type(attr_name)
columns_hash[attr_name.to_s].type
end
def define_attribute_methods def define_attribute_methods
super.tap do |attribute_methods_generated| super.tap do |attribute_methods_generated|
use_before_type_cast = ValidatesTimeliness::ORM::ActiveRecord.use_plugin_cache? use_before_type_cast = ValidatesTimeliness::ORM::ActiveRecord.use_plugin_cache?
@ -24,10 +35,9 @@ module ValidatesTimeliness
end end
end end
def define_timeliness_methods(before_type_cast=false) protected
return if timeliness_validated_attributes.blank?
timeliness_validated_attributes.each do |attr_name| def define_attribute_timeliness_methods(attr_name, before_type_cast=false)
if before_type_cast if before_type_cast
define_timeliness_write_method(attr_name) define_timeliness_write_method(attr_name)
define_timeliness_before_type_cast_method(attr_name) define_timeliness_before_type_cast_method(attr_name)
@ -35,7 +45,6 @@ module ValidatesTimeliness
define_timeliness_write_method_without_cache(attr_name) define_timeliness_write_method_without_cache(attr_name)
end end
end end
end
def define_timeliness_write_method_without_cache(attr_name) def define_timeliness_write_method_without_cache(attr_name)
method_body, line = <<-EOV, __LINE__ + 1 method_body, line = <<-EOV, __LINE__ + 1
@ -49,15 +58,6 @@ module ValidatesTimeliness
generated_timeliness_methods.module_eval(method_body, __FILE__, line) generated_timeliness_methods.module_eval(method_body, __FILE__, line)
end end
def timeliness_attribute_timezone_aware?(attr_name)
attr_name = attr_name.to_s
create_time_zone_conversion_attribute?(attr_name, columns_hash[attr_name])
end
def timeliness_attribute_type(attr_name)
columns_hash[attr_name.to_s].type
end
def timeliness_type_cast_code(attr_name, var_name) def timeliness_type_cast_code(attr_name, var_name)
type = timeliness_attribute_type(attr_name) type = timeliness_attribute_type(attr_name)