From 7f1ada4d0ebbf6a66f38518d9678814155968911 Mon Sep 17 00:00:00 2001
From: Adam Meehan <adam.meehan@gmail.com>
Date: Tue, 8 Jul 2008 10:44:43 +1000
Subject: [PATCH] refactored specs into type validations, added some more
 examples for boundary checks

---
 spec/validations_spec.rb | 140 ++++++++++++++++++++++++++++++++++-----
 1 file changed, 122 insertions(+), 18 deletions(-)

diff --git a/spec/validations_spec.rb b/spec/validations_spec.rb
index 6d4258b..a4751e3 100644
--- a/spec/validations_spec.rb
+++ b/spec/validations_spec.rb
@@ -2,6 +2,7 @@ require File.dirname(__FILE__) + '/spec_helper'
 
 describe ValidatesTimeliness::Validations do
   before :all do
+    # freezes time using time_travel plugin
     Time.now = Time.utc(2008, 1, 1, 12, 0, 0)
   end
   
@@ -14,6 +15,7 @@ describe ValidatesTimeliness::Validations do
       class BasicValidation < Person
         validates_timeliness_of :birth_date_and_time, :allow_blank => true, :type => :datetime
         validates_timeliness_of :birth_date, :allow_blank => true, :type => :date
+        validates_timeliness_of :birth_time, :allow_blank => true, :type => :time
       end
     end
 
@@ -21,24 +23,30 @@ describe ValidatesTimeliness::Validations do
       @person = BasicValidation.new
     end
 
-    it "should have error for invalid date component for Time column" do
+    it "should have error for invalid date component for datetime column" do
       @person.birth_date_and_time = "1980-02-30 01:02:03"
       @person.should_not be_valid
       @person.errors.on(:birth_date_and_time).should == "is not a valid datetime"
     end
 
-    it "should have error for invalid time component for Time column" do
+    it "should have error for invalid time component for datetime column" do
       @person.birth_date_and_time = "1980-02-30 25:02:03"
       @person.should_not be_valid 
       @person.errors.on(:birth_date_and_time).should == "is not a valid datetime"
     end
 
-    it "should have error for invalid date value for Date column" do
+    it "should have error for invalid date value for date column" do
       @person.birth_date = "1980-02-30"
       @person.should_not be_valid
       @person.errors.on(:birth_date).should == "is not a valid date"
     end
 
+    it "should have error for invalid time value for time column" do
+      @person.birth_time = "25:00"
+      @person.should_not be_valid
+      @person.errors.on(:birth_time).should == "is not a valid time"
+    end
+
     it "should be valid with valid values" do
       @person.birth_date_and_time = "1980-01-31 12:12:12"
       @person.birth_date = "1980-01-31"
@@ -48,27 +56,30 @@ describe ValidatesTimeliness::Validations do
     it "should be valid with values before epoch" do
       @person.birth_date_and_time = "1960-01-31 12:12:12"
       @person.birth_date = "1960-01-31"
+      @person.birth_time = "23:59"
       @person.should be_valid
     end
     
     it "should be valid with nil values when allow_blank si true" do
       @person.birth_date_and_time = nil
       @person.birth_date = nil
+      @person.birth_time = nil      
       @person.should be_valid
     end
   end
   
-  describe "for Time attribute" do
+  describe "for datetime type" do
     
     describe "with before and after restrictions" do
       before :all do
-        class TimeBeforeAfter < Person
-          validates_timeliness_of :birth_date_and_time, :before => Time.now, :after => 1.day.ago
+        class DateTimeBeforeAfter < Person
+          validates_timeliness_of :birth_date_and_time, :type => :datetime,
+            :before => Time.now, :after => 1.day.ago
         end
       end
 
       before :each do
-        @person = TimeBeforeAfter.new
+        @person = DateTimeBeforeAfter.new
       end
       
       it "should have error when past :before restriction" do
@@ -98,13 +109,15 @@ describe ValidatesTimeliness::Validations do
 
     describe "with on_or_before and on_or_after restrictions" do
       before :all do
-        class TimeOnOrBeforeAndAfter < Person
-          validates_timeliness_of :birth_date_and_time, :on_or_before => Time.now.at_midnight, :on_or_after => 1.day.ago
+        class DateTimeOnOrBeforeAndAfter < Person
+          validates_timeliness_of :birth_date_and_time, :type => :datetime,
+            :on_or_before => Time.now.at_midnight, 
+            :on_or_after => 1.day.ago
         end
       end
       
       before do  
-        @person = TimeOnOrBeforeAndAfter.new
+        @person = DateTimeOnOrBeforeAndAfter.new
       end
         
       it "should have error when past :on_or_before restriction" do
@@ -132,11 +145,13 @@ describe ValidatesTimeliness::Validations do
 
   end
   
-  describe "with Date attribute" do
+  describe "for date type" do
     describe "with before and after restrictions" do
       before :all do
         class DateBeforeAfter < Person
-          validates_timeliness_of :birth_date, :before => 1.day.from_now.to_date, :after => 1.day.ago.to_date          
+          validates_timeliness_of :birth_date, :type => :date,
+            :before => 1.day.from_now, 
+            :after => 1.day.ago
         end        
       end
 
@@ -145,13 +160,13 @@ describe ValidatesTimeliness::Validations do
       end
       
       it "should have error when past :before restriction" do
-        @person.birth_date = 2.days.from_now.to_date
+        @person.birth_date = 2.days.from_now
         @person.should_not be_valid
         @person.errors.on(:birth_date).should match(/must be before/)
       end
 
       it "should have error when before :after restriction" do
-        @person.birth_date = 2.days.ago.to_date
+        @person.birth_date = 2.days.ago
         @person.should_not be_valid
         @person.errors.on(:birth_date).should match(/must be after/)
       end
@@ -160,7 +175,9 @@ describe ValidatesTimeliness::Validations do
     describe "with on_or_before and on_or_after restrictions" do
       before :all do
         class DateOnOrBeforeAndAfter < Person
-          validates_timeliness_of :birth_date, :on_or_before => 1.day.from_now.to_date, :on_or_after => 1.day.ago.to_date, :type => :date
+          validates_timeliness_of :birth_date, :type => :date, 
+            :on_or_before => 1.day.from_now,
+            :on_or_after => 1.day.ago
         end
       end
       
@@ -169,7 +186,7 @@ describe ValidatesTimeliness::Validations do
       end
         
       it "should have error when past :on_or_before restriction" do
-        @person.birth_date = 2.days.from_now.to_date
+        @person.birth_date = 2.days.from_now
         @person.should_not be_valid
         @person.errors.on(:birth_date).should match(/must be on or before/)
       end
@@ -181,17 +198,104 @@ describe ValidatesTimeliness::Validations do
       end
       
       it "should be valid when value equal to :on_or_before restriction" do
-        @person.birth_date = 1.day.from_now.to_date
+        @person.birth_date = 1.day.from_now
         @person.should be_valid
       end
 
       it "should be valid when value equal to :on_or_after restriction" do
-        @person.birth_date = 1.day.ago.to_date
+        @person.birth_date = 1.day.ago
         @person.should be_valid        
       end      
     end 
   end
   
+  describe "for time type" do
+    describe "with before and after restrictions" do
+      before :all do
+        class TimeBeforeAfter < Person
+          validates_timeliness_of :birth_time, :type => :time,
+            :before => "23:00", 
+            :after => "06:00"
+        end        
+      end
+
+      before :each do
+        @person = TimeBeforeAfter.new
+      end
+      
+      it "should have error when on boundary of :before restriction" do
+        @person.birth_time = "23:00"
+        @person.should_not be_valid
+        @person.errors.on(:birth_time).should match(/must be before/)
+      end
+
+      it "should have error when on boundary of :after restriction" do
+        @person.birth_time = "6:00"
+        @person.should_not be_valid
+        @person.errors.on(:birth_time).should match(/must be after/)
+      end
+      
+      it "should have error when past :before restriction" do
+        @person.birth_time = "23:01"
+        @person.should_not be_valid
+        @person.errors.on(:birth_time).should match(/must be before/)
+      end
+
+      it "should have error when before :after restriction" do
+        @person.birth_time = "5:59"
+        @person.should_not be_valid
+        @person.errors.on(:birth_time).should match(/must be after/)
+      end
+      
+      it "should not have error when before :before restriction" do
+        @person.birth_time = "22:59"
+        @person.should be_valid
+      end
+
+      it "should have error when before :after restriction" do
+        @person.birth_time = "6:01"
+        @person.should be_valid
+      end
+    end
+
+    describe "with on_or_before and on_or_after restrictions" do
+      before :all do
+        class TimeOnOrBeforeAndAfter < Person
+          validates_timeliness_of :birth_time, :type => :time,
+            :on_or_before => "23:00",
+            :on_or_after => "06:00"
+        end
+      end
+      
+      before :each do
+        @person = TimeOnOrBeforeAndAfter.new
+      end
+        
+      it "should have error when past :on_or_before restriction" do
+        @person.birth_time = "23:01"
+        @person.should_not be_valid
+        @person.errors.on(:birth_time).should match(/must be on or before/)
+      end
+
+      it "should have error when before :on_or_after restriction" do
+        @person.birth_time = "5:59"
+        @person.should_not be_valid
+        @person.errors.on(:birth_time).should match(/must be on or after/)
+      end
+      
+      it "should be valid when on boundary of :on_or_before restriction" do
+        @person.birth_time = "23:00"
+        @person.should be_valid
+      end
+
+      it "should be valid when on boundary of :on_or_after restriction" do
+        @person.birth_time = "6:00"
+        @person.should be_valid        
+      end      
+    end 
+  end
+  
+  
   describe "with mixed value and restriction types" do
     before :all do
       class MixedBeforeAndAfter < Person