From 75f3ef34e8b18027a78e20530f2d82bb5c448fcb Mon Sep 17 00:00:00 2001 From: Adam Meehan Date: Fri, 5 Dec 2008 20:35:37 +1100 Subject: [PATCH] made parameters explicit for validates_timeliness since its private and should not be used directly for validation --- lib/validates_timeliness/validation_methods.rb | 3 +-- spec/validation_methods_spec.rb | 8 -------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/validates_timeliness/validation_methods.rb b/lib/validates_timeliness/validation_methods.rb index dc37302..18927aa 100644 --- a/lib/validates_timeliness/validation_methods.rb +++ b/lib/validates_timeliness/validation_methods.rb @@ -48,8 +48,7 @@ module ValidatesTimeliness private - def validates_timeliness_of(*attr_names) - configuration = attr_names.extract_options! + def validates_timeliness_of(attr_names, configuration) validator = ValidatesTimeliness::Validator.new(configuration) # bypass handling of allow_nil and allow_blank to validate raw value diff --git a/spec/validation_methods_spec.rb b/spec/validation_methods_spec.rb index 15997e1..e231599 100644 --- a/spec/validation_methods_spec.rb +++ b/spec/validation_methods_spec.rb @@ -45,12 +45,4 @@ describe ValidatesTimeliness::ValidationMethods do ActiveRecord::Base.parse_date_time(*args) end end - - # it "should have same value for before_type_cast after failed validation" do - # person.birth_date_and_time = "2000-01-01 25:02:03" - # person.should_not be_valid - # person.birth_date_and_time_before_type_cast.should == "2000-01-01 25:02:03" - # end - # - end