Merge pull request #148 from ralimi/support-starlark

Add support for Starlark.
This commit is contained in:
Alastair Mooney 2023-02-28 13:41:56 +00:00 committed by GitHub
commit c1b7b83308
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 41 additions and 4 deletions

View File

@ -188,6 +188,15 @@
} }
] ]
}, },
{
"language": "Starlark",
"markers": [
{
"type": "line",
"pattern": "#"
}
]
},
{ {
"language": "TypeScript", "language": "TypeScript",
"markers": [ "markers": [

View File

@ -159,6 +159,12 @@ index 0000000..7cccc5b
- also need to be turned into task, and hopefully - also need to be turned into task, and hopefully
- kept together as one. - kept together as one.
- =# - =#
diff --git a/tests/defs.bzl b/tests/defs.bzl
index 525e25d..ba4e68d 100644
--- a/tests/defs.bzl
+++ b/tests/defs.bzl
@@ -0,0 +0,1 @@
- # TODO: Come up with a more imaginative greeting
diff --git a/tests/example_file.ahk b/src/tests/example_file.ahk diff --git a/tests/example_file.ahk b/src/tests/example_file.ahk
new file mode 100644 new file mode 100644
index 0000000..7cccc5b index 0000000..7cccc5b

View File

@ -187,6 +187,20 @@ index 0000000..7cccc5b
+ also need to be turned into task, and hopefully + also need to be turned into task, and hopefully
+ kept together as one. + kept together as one.
+ =# + =#
diff --git a/tests/defs.bzl b/tests/defs.bzl
new file mode 100644
index 0000000..525e25d
--- /dev/null
+++ b/tests/defs.bzl
@@ -0,0 +1,23 @@
+def hello_world():
+ # TODO: Come up with a more imaginative greeting
+ print('Hello world')
+
+ # TODO: Do more stuff
+ # This function should probably do something more interesting
+ # labels: help wanted
+ pass
diff --git a/tests/example_file.ahk b/src/tests/example_file.ahk diff --git a/tests/example_file.ahk b/src/tests/example_file.ahk
new file mode 100644 new file mode 100644
index 0000000..7cccc5b index 0000000..7cccc5b

View File

@ -23,7 +23,8 @@ class NewIssueTests(unittest.TestCase):
self.raw_issues = parser.parse(diff_file) self.raw_issues = parser.parse(diff_file)
def test_python_issues(self): def test_python_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 4) # Includes 2 tests for Starlark.
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 6)
def test_yaml_issues(self): def test_yaml_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2)
@ -53,6 +54,9 @@ class NewIssueTests(unittest.TestCase):
def test_julia_issues(self): def test_julia_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'julia'), 2) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'julia'), 2)
def test_starlark_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 6)
def test_autohotkey_issues(self): def test_autohotkey_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'autohotkey'), 1) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'autohotkey'), 1)
@ -96,7 +100,8 @@ class ClosedIssueTests(unittest.TestCase):
self.raw_issues = parser.parse(diff_file) self.raw_issues = parser.parse(diff_file)
def test_python_issues(self): def test_python_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 4) # Includes 1 test for Starlark.
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 5)
def test_yaml_issues(self): def test_yaml_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2)
@ -123,6 +128,9 @@ class ClosedIssueTests(unittest.TestCase):
def test_julia_issues(self): def test_julia_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'julia'), 2) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'julia'), 2)
def test_starlark_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 5)
def test_json5_issues(self): def test_json5_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'javascript'), 1) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'javascript'), 1)
@ -168,7 +176,7 @@ class IgnorePatternTests(unittest.TestCase):
parser.syntax_dict = json.load(syntax_json) parser.syntax_dict = json.load(syntax_json)
diff_file = open('tests/test_closed.diff', 'r') diff_file = open('tests/test_closed.diff', 'r')
self.raw_issues = parser.parse(diff_file) self.raw_issues = parser.parse(diff_file)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 4) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 5)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'php'), 4) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'php'), 4)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'java'), 0) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'java'), 0)
@ -183,7 +191,7 @@ class IgnorePatternTests(unittest.TestCase):
parser.syntax_dict = json.load(syntax_json) parser.syntax_dict = json.load(syntax_json)
diff_file = open('tests/test_closed.diff', 'r') diff_file = open('tests/test_closed.diff', 'r')
self.raw_issues = parser.parse(diff_file) self.raw_issues = parser.parse(diff_file)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 4) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 5)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'php'), 0) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'php'), 0)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'java'), 0) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'java'), 0)