From b4b115f0605cfdecde3f99aea3b6ffe9a723093c Mon Sep 17 00:00:00 2001 From: Robert Alonso <17463757+rgalonso@users.noreply.github.com> Date: Fri, 8 Nov 2024 20:49:19 +0000 Subject: [PATCH] fix: escape title when searching for comment line If regex characters are part of the title (for example, parentheses), then this breaks the ability to find the comment line when trying to insert the issue URL. This commit escapes the title to fix this problem. Closes github.com/alstr/todo-to-issue-action#226 --- main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.py b/main.py index 4672beb..c0db054 100644 --- a/main.py +++ b/main.py @@ -76,7 +76,7 @@ def process_diff(diff, client=Client(), insert_issue_urls=False, parser=TodoPars if line_number < len(file_lines): # Duplicate the line to retain the comment syntax. old_line = file_lines[line_number] - remove = fr'(?i:{raw_issue.identifier}).*{raw_issue.title}' + remove = fr'(?i:{raw_issue.identifier}).*{re.escape(raw_issue.title)}' insert = f'Issue URL: {client.get_issue_url(new_issue_number)}' new_line = re.sub(remove, insert, old_line) # make sure the above operation worked as intended