code review

This commit is contained in:
Miguel Palhas 2024-10-08 12:16:19 +01:00
parent 7b5d19e941
commit 94022cee51
5 changed files with 31 additions and 8 deletions

View File

@ -848,8 +848,8 @@
{ {
"type": "block", "type": "block",
"pattern": { "pattern": {
"start": "--[[", "start": "--\\[\\[",
"end": "--]]" "end": "--\\]\\]"
} }
} }
] ]

View File

@ -483,3 +483,20 @@ index 525e25d..ba4e68d 100644
-TODO: Create an issue for TODO -TODO: Create an issue for TODO
--} --}
-sum a b = a + b -sum a b = a + b
diff --git a/init.lua b/init.lua
new file mode 100644
index 0000000..0ce9b1a
--- a/init.lua
+++ b/init.lua
@@ -0,0 +1,11 @@
--- TODO: Fix this
--- In the future, make a way to build these and just start the base
--- out with a large supply of each
--- labels: redesign
-local a = 1
-
---[[
- TODO: Fix this todo
- labels: urgent
---]]
-local b = 2

View File

@ -539,17 +539,20 @@ index 0000000..0ce9b1a
+TODO: Create an issue for TODO +TODO: Create an issue for TODO
+-} +-}
+sum a b = a + b +sum a b = a + b
diff --git a/src/init.lua b/src/init.lua diff --git a/init.lua b/init.lua
new file mode 100644 new file mode 100644
index 0000000..0ce9b1a index 0000000..0ce9b1a
--- /dev/null --- /dev/null
+++ b/src/init.lua +++ b/init.lua
@@ -0,0 +1,8 @@ @@ -0,0 +1,11 @@
+-- TODO: Fix this +-- TODO: Fix this
+-- In the future, make a way to build these and just start the base +-- In the future, make a way to build these and just start the base
+-- out with a large supply of each +-- out with a large supply of each
+-- labels: redesign +-- labels: redesign
+local a = 1
+
+--[[ +--[[
+ TODO: Fix this todo + TODO: Fix this todo
+ labels: urgent + labels: urgent
+--]] +--]]
+local b = 2

View File

@ -100,8 +100,8 @@ class NewIssueTests(unittest.TestCase):
def test_liquid_issues(self): def test_liquid_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'liquid'), 3) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'liquid'), 3)
def test_liquid_issues(self): def test_lua_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'lua'), 3) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'lua'), 2)
class ClosedIssueTests(unittest.TestCase): class ClosedIssueTests(unittest.TestCase):
# Check for removed TODOs across the files specified. # Check for removed TODOs across the files specified.
@ -190,6 +190,9 @@ class ClosedIssueTests(unittest.TestCase):
def test_liquid_issues(self): def test_liquid_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'liquid'), 3) self.assertEqual(count_issues_for_file_type(self.raw_issues, 'liquid'), 3)
def test_lua_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'lua'), 2)
class IgnorePatternTests(unittest.TestCase): class IgnorePatternTests(unittest.TestCase):