code review

This commit is contained in:
Miguel Palhas
2024-10-09 18:21:46 +01:00
6 changed files with 65 additions and 14 deletions

View File

@@ -65,7 +65,7 @@ class NewIssueTests(unittest.TestCase):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'handlebars'), 2)
def test_org_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'text'), 8)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'text'), 12)
def test_scss_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'scss'), 2)
@@ -100,10 +100,10 @@ class NewIssueTests(unittest.TestCase):
def test_liquid_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'liquid'), 3)
def test_solidity_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'solidity'), 4)
def test_lua_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'lua'), 2)
class ClosedIssueTests(unittest.TestCase):
class ClosedIssueTest(unittest.TestCase):
# Check for removed TODOs across the files specified.
def setUp(self):
diff_file = open('tests/test_closed.diff', 'r')
@@ -155,7 +155,7 @@ class ClosedIssueTests(unittest.TestCase):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'handlebars'), 2)
def test_org_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'text'), 8)
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'text'), 12)
def test_scss_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'scss'), 2)
@@ -190,9 +190,8 @@ class ClosedIssueTests(unittest.TestCase):
def test_liquid_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'liquid'), 3)
def test_solidity_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'solidity'), 4)
def test_lua_issues(self):
self.assertEqual(count_issues_for_file_type(self.raw_issues, 'lua'), 2)
class IgnorePatternTests(unittest.TestCase):