ditkrg/todo-to-issue-action
4
0
Fork 0
mirror of https://github.com/ditkrg/todo-to-issue-action.git synced 2026-01-22 22:06:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve checks for existing issues

Browse Source
This commit is contained in:
alstr 2020-05-28 14:03:44 +01:00
parent 27e63bb04e
commit 4ed02ed621
1 changed files with 70 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

117
main.py
View File

@ -8,6 +8,7 @@ import json
from time import sleep from time import sleep
from io import StringIO from io import StringIO
from ruamel.yaml import YAML from ruamel.yaml import YAML
import hashlib
base_url = 'https://api.github.com/repos/' base_url = 'https://api.github.com/repos/'
@ -36,6 +37,17 @@ def main():
yaml = YAML(typ='safe') yaml = YAML(typ='safe')
languages_dict = yaml.load(languages_data) languages_dict = yaml.load(languages_data)
# Get the current issues so we can check we're not duplicating any, and so we can close any that have been removed.
issues_url = f'{base_url}{repo}/issues'
issue_headers = {
'Content-Type': 'application/json',
'Authorization': f'token {token}'
}
current_issues = []
list_issues_request = requests.get(issues_url, headers=issue_headers)
if list_issues_request.status_code == 200:
current_issues = list_issues_request.json()
diff_request = requests.get(url=diff_url, headers=diff_headers) diff_request = requests.get(url=diff_url, headers=diff_headers)
if diff_request.status_code == 200: if diff_request.status_code == 200:
diff = diff_request.text diff = diff_request.text
@ -122,7 +134,7 @@ def main():
deletion = deletion_search.group(0) deletion = deletion_search.group(0)
todo_search = todo_pattern.search(deletion) todo_search = todo_pattern.search(deletion)
if todo_search: if todo_search:
closed_issues.append(todo_search.group(0)) closed_issues.append(todo_search.group(0).lstrip())
else: else:
lines.append(cleaned_line[1:]) lines.append(cleaned_line[1:])
@ -143,11 +155,7 @@ def main():
new_issues.append(curr_issue) new_issues.append(curr_issue)
# Create new issues for any newly added TODOs. # Create new issues for any newly added TODOs.
issues_url = f'{base_url}{repo}/issues' print('Start creating issues')
issue_headers = {
'Content-Type': 'application/json',
'Authorization': f'token {token}'
}
for i, issue in enumerate(new_issues): for i, issue in enumerate(new_issues):
title = issue['todo'] title = issue['todo']
# Truncate the title if it's longer than 50 chars. # Truncate the title if it's longer than 50 chars.
@ -171,50 +179,65 @@ def main():
body += '\n\n' + '```' + markdown_language + '\n' + '\n'.join(hunk) + '\n' + '```' body += '\n\n' + '```' + markdown_language + '\n' + '\n'.join(hunk) + '\n' + '```'
else: else:
body += '\n\n' + '```' + '\n'.join(hunk) + '\n' + '```' body += '\n\n' + '```' + '\n'.join(hunk) + '\n' + '```'
new_issue_body = {'title': title, 'body': body, 'labels': ['todo']}
new_issue_request = requests.post(url=issues_url, headers=issue_headers, data=json.dumps(new_issue_body)) # Check if the current issue already exists - if so, skip it.
print(f'Creating issue {i + 1} of {len(new_issues)}') issue_id = hashlib.sha1(body.encode('utf-8')).hexdigest()
# TODO Investigate result not being printed on last loop when adding multiple new TODOs body += '\n\n' + issue_id
# See https://github.com/alstr/todo-to-issue-action/issues/7#issuecomment-630694673 for current_issue in current_issues:
# Could the log be being truncated? if issue_id in current_issue['body']:
if new_issue_request.status_code == 201: print(f'Skipping issue {i + 1} of {len(new_issues)} (already exists)')
print('Issue created') break
else: else:
print('Issue could not be created') new_issue_body = {'title': title, 'body': body, 'labels': ['todo']}
# Don't add too many issues too quickly. new_issue_request = requests.post(url=issues_url, headers=issue_headers,
sleep(1) data=json.dumps(new_issue_body))
print(f'Creating issue {i + 1} of {len(new_issues)}')
# TODO Investigate result not being printed on last loop when adding multiple new TODOs
# See https://github.com/alstr/todo-to-issue-action/issues/7#issuecomment-630694673
# Could the log be being truncated?
if new_issue_request.status_code == 201:
print('Issue created')
else:
print('Issue could not be created')
# Don't add too many issues too quickly.
sleep(1)
print('Creating issues complete')
if len(closed_issues) > 0: # Close issues for removed TODOs.
# Get the list of current issues. print('Start closing issues')
list_issues_request = requests.get(issues_url, headers=issue_headers) for i, closed_issue in enumerate(closed_issues):
if list_issues_request.status_code == 200: title = closed_issue
current_issues = list_issues_request.json() matched = 0
for i, closed_issue in enumerate(closed_issues): issue_number = None
title = closed_issue # Compare the title of each closed issue with each issue in the issues list.
if len(title) > 50: for current_issue in current_issues:
title = closed_issue[:50] + '...' if current_issue['body'].startswith(title):
matched += 1
# If there are multiple issues with similar titles, don't try and close any.
if matched > 1:
print(f'Skipping issue {i + 1} of {len(closed_issues)} (multiple matches)')
break
issue_number = current_issue['number']
else:
if issue_number is None:
continue
# The titles match, so we will try and close the issue.
update_issue_url = f'{base_url}{repo}/issues/{issue_number}'
body = {'state': 'closed'}
requests.patch(update_issue_url, headers=issue_headers, data=json.dumps(body))
# Compare the title of each closed issue with each issue in the issues list. issue_comment_url = f'{base_url}{repo}/issues/{issue_number}/comments'
for current_issue in current_issues: body = {'body': f'Closed in {sha}'}
if current_issue['title'] == title: update_issue_request = requests.post(issue_comment_url, headers=issue_headers,
# The titles match, so we will try and close the issue. data=json.dumps(body))
issue_number = current_issue['number'] print(f'Closing issue {i + 1} of {len(closed_issues)}')
if update_issue_request.status_code == 201:
update_issue_url = f'{base_url}{repo}/issues/{issue_number}' print('Issue closed')
body = {'state': 'closed'} else:
requests.patch(update_issue_url, headers=issue_headers, data=json.dumps(body)) print('Issue could not be closed')
# Don't update too many issues too quickly.
issue_comment_url = f'{base_url}{repo}/issues/{issue_number}/comments' sleep(1)
body = {'body': f'Closed in {sha}'} print('Closing issues complete')
update_issue_request = requests.post(issue_comment_url, headers=issue_headers,
data=json.dumps(body))
print(f'Closing issue {i + 1} of {len(closed_issues)}')
if update_issue_request.status_code == 201:
print('Issue closed')
else:
print('Issue could not be closed')
# Don't update too many issues too quickly.
sleep(1)
if __name__ == "__main__": if __name__ == "__main__":