ditkrg/todo-to-issue-action
4
0
Fork 0
mirror of https://github.com/ditkrg/todo-to-issue-action.git synced 2026-01-22 22:06:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: consolidate test classes

Browse Source 
I initially thought it a good idea to split these
up, but it led to a lot of unnnecessary code
redundancy. This is a better approach.
This commit is contained in:
Robert Alonso 2024-11-09 19:56:03 +00:00
parent 325fbaf03b
commit 30b3d43dec
1 changed files with 9 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
tests/test_process_diff.py
View File

@ -9,7 +9,7 @@ from TodoParser import TodoParser
from main import process_diff from main import process_diff
class ProcessDiffTestBase(unittest.TestCase): class IssueUrlInsertionTest(unittest.TestCase):
orig_cwd = None orig_cwd = None
tempdir = None tempdir = None
diff_file = None diff_file = None
@ -47,37 +47,24 @@ class ProcessDiffTestBase(unittest.TestCase):
expected_count, expected_count,
msg='\nProcessing log\n--------------\n'+output.getvalue()) msg='\nProcessing log\n--------------\n'+output.getvalue())
def _tearDown(self):
# return to original working directory to ensure we don't mess up other tests
os.chdir(self.orig_cwd)
# explicitly cleanup to avoid warning being printed about implicit cleanup
self.tempdir.cleanup()
self.tempdir = None
class IssueUrlInsertionTest(ProcessDiffTestBase):
def setUp(self):
return super()._setUp('test_new.diff')
# this test can take a while and, as far as TodoParser is concerned, # this test can take a while and, as far as TodoParser is concerned,
# redundant with the tests of test_todo_parser, so enable the means # redundant with the tests of test_todo_parser, so enable the means
# to skip it if desired # to skip it if desired
@unittest.skipIf(os.getenv('SKIP_PROCESS_DIFF_TEST', 'false') == 'true', @unittest.skipIf(os.getenv('SKIP_PROCESS_DIFF_TEST', 'false') == 'true',
"Skipping because 'SKIP_PROCESS_DIFF_TEST' is 'true'") "Skipping because 'SKIP_PROCESS_DIFF_TEST' is 'true'")
def test_url_insertion(self): def test_url_insertion(self):
self._setUp('test_new.diff')
self._standardTest(80) self._standardTest(80)
def tearDown(self):
return super()._tearDown()
class IdenticalTodoTest(ProcessDiffTestBase):
def setUp(self):
return super()._setUp('test_same_title_in_same_file.diff')
@unittest.expectedFailure @unittest.expectedFailure
def test_same_title_in_same_file(self): def test_same_title_in_same_file(self):
self._setUp('test_same_title_in_same_file.diff')
self._standardTest(5) self._standardTest(5)
def tearDown(self): def tearDown(self):
return super()._tearDown() # return to original working directory to ensure we don't mess up other tests
os.chdir(self.orig_cwd)
# explicitly cleanup to avoid warning being printed about implicit cleanup
self.tempdir.cleanup()
self.tempdir = None