From 832535b4cf387e1485532d5fa3037728831e5852 Mon Sep 17 00:00:00 2001 From: Caspian Baska Date: Wed, 2 Mar 2022 01:14:04 +1100 Subject: [PATCH 1/3] feat: add support for Crystal language --- README.md | 1 + syntax.json | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/README.md b/README.md index 98df110..40e1a8b 100644 --- a/README.md +++ b/README.md @@ -73,6 +73,7 @@ There are additional inputs if you want to be able to assign issues to projects. * C++ * C# * CSS +* Crystal * Dart * Elixir * Go diff --git a/syntax.json b/syntax.json index 60f79c7..374112e 100644 --- a/syntax.json +++ b/syntax.json @@ -591,5 +591,14 @@ } } ] + }, + { + "language": "Crystal", + "markers": [ + { + "type": "line", + "pattern": "#" + } + ] } ] From 74e76203e878f8a8fbdc869935426799de114ef1 Mon Sep 17 00:00:00 2001 From: Caspian Baska Date: Wed, 2 Mar 2022 01:21:04 +1100 Subject: [PATCH 2/3] test: new and closed for crystal --- tests/test_closed.diff | 13 ++++++++++++- tests/test_new.diff | 12 ++++++++++++ tests/test_todo_parser.py | 16 +++++++++++----- 3 files changed, 35 insertions(+), 6 deletions(-) diff --git a/tests/test_closed.diff b/tests/test_closed.diff index f42c460..d7190f1 100644 --- a/tests/test_closed.diff +++ b/tests/test_closed.diff @@ -75,6 +75,17 @@ index 525e25d..ba4e68d 100644 - kept together as one. - ''' - pass +diff --git a/tests/example_file.cr b/tests/example_file.cr +index e6da2ec..67f14dd 100644 +--- a/tests/example_file.cr ++++ b/tests/example_file.cr +@@ -1,14 +1,3 @@ +-# TODO: Come up with a more imaginative greeting + puts "Greetings" +- +-# TODO: Do even more stuff +-# This function should probably do something more interesting +-# labels: help wanted diff --git a/tests/example_file.rb b/tests/example_file.rb index e6da2ec..67f14dd 100644 --- a/tests/example_file.rb @@ -210,4 +221,4 @@ index 525e25d..ba4e68d 100644 - TODO:Multiline comments - also need to be turned into todos, and hopefully - kept together as one todo -- #} \ No newline at end of file +- #} diff --git a/tests/test_new.diff b/tests/test_new.diff index 805b2a2..690698e 100644 --- a/tests/test_new.diff +++ b/tests/test_new.diff @@ -78,6 +78,18 @@ index 0000000..525e25d + ''' + pass \ No newline at end of file +diff --git a/tests/example_file.cr b/tests/example_file.cr +new file mode 100644 +index 0000000..e6da2ec +--- /dev/null ++++ b/tests/example_file.cr +@@ -0,0 +1,14 @@ ++# TODO: Come up with a more imaginative greeting ++puts "Greetings" ++ ++# TODO: Do even more stuff ++# This function should probably do something more interesting ++# labels: help wanted diff --git a/tests/example_file.rb b/tests/example_file.rb new file mode 100644 index 0000000..e6da2ec diff --git a/tests/test_todo_parser.py b/tests/test_todo_parser.py index aaf40af..c8861a7 100644 --- a/tests/test_todo_parser.py +++ b/tests/test_todo_parser.py @@ -33,6 +33,9 @@ class NewIssueTests(unittest.TestCase): def test_java_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'java'), 2) + def test_crystal_issues(self): + self.assertEqual(count_issues_for_file_type(self.raw_issues, 'crystal'), 2) + def test_ruby_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'ruby'), 3) @@ -50,10 +53,10 @@ class NewIssueTests(unittest.TestCase): def test_autohotkey_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'autohotkey'), 1) - + def test_handlebars_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'handlebars'), 2) - + def test_org_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'text'), 2) @@ -85,6 +88,9 @@ class ClosedIssueTests(unittest.TestCase): def test_java_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'java'), 2) + def test_crystal_issues(self): + self.assertEqual(count_issues_for_file_type(self.raw_issues, 'crystal'), 2) + def test_ruby_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'ruby'), 3) @@ -96,16 +102,16 @@ class ClosedIssueTests(unittest.TestCase): def test_tex_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'tex'), 2) - + def test_julia_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'julia'), 2) def test_autohotkey_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'autohotkey'), 1) - + def test_handlebars_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'handlebars'), 2) - + def test_org_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'text'), 2) From 5a4b496ded2911b3b1c8964793dfdae8c8ec67c4 Mon Sep 17 00:00:00 2001 From: alstr Date: Fri, 4 Mar 2022 13:24:45 +0000 Subject: [PATCH 3/3] Update tests --- tests/test_todo_parser.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/test_todo_parser.py b/tests/test_todo_parser.py index c8861a7..b737451 100644 --- a/tests/test_todo_parser.py +++ b/tests/test_todo_parser.py @@ -37,7 +37,8 @@ class NewIssueTests(unittest.TestCase): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'crystal'), 2) def test_ruby_issues(self): - self.assertEqual(count_issues_for_file_type(self.raw_issues, 'ruby'), 3) + # Includes 2 tests for Crystal. + self.assertEqual(count_issues_for_file_type(self.raw_issues, 'ruby'), 5) def test_abap_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'abap'), 2) @@ -88,11 +89,9 @@ class ClosedIssueTests(unittest.TestCase): def test_java_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'java'), 2) - def test_crystal_issues(self): - self.assertEqual(count_issues_for_file_type(self.raw_issues, 'crystal'), 2) - def test_ruby_issues(self): - self.assertEqual(count_issues_for_file_type(self.raw_issues, 'ruby'), 3) + # Includes 2 tests for Crystal. + self.assertEqual(count_issues_for_file_type(self.raw_issues, 'ruby'), 5) def test_abap_issues(self): self.assertEqual(count_issues_for_file_type(self.raw_issues, 'abap'), 2)