From b8928ee1ea0d9b7ae530d2d6d705cfd9f6e80b24 Mon Sep 17 00:00:00 2001 From: Muhammad Nawzad Date: Mon, 13 Nov 2023 15:50:28 +0300 Subject: [PATCH] Uses attribute reader instead of accessor --- lib/schemable/attribute_schema_generator.rb | 2 +- lib/schemable/included_schema_generator.rb | 2 +- lib/schemable/relationship_schema_generator.rb | 2 +- lib/schemable/request_schema_generator.rb | 2 +- lib/schemable/response_schema_generator.rb | 2 +- sig/schemable/attribute_schema_generator.rbs | 10 +++++----- sig/schemable/included_schema_generator.rbs | 9 +++------ sig/schemable/relationship_schema_generator.rbs | 6 +++--- sig/schemable/request_schema_generator.rbs | 4 ++-- sig/schemable/response_schema_generator.rbs | 6 +++--- 10 files changed, 21 insertions(+), 24 deletions(-) diff --git a/lib/schemable/attribute_schema_generator.rb b/lib/schemable/attribute_schema_generator.rb index b0aa60b..bcf5b08 100644 --- a/lib/schemable/attribute_schema_generator.rb +++ b/lib/schemable/attribute_schema_generator.rb @@ -1,6 +1,6 @@ module Schemable class AttributeSchemaGenerator - attr_accessor :model_definition, :configuration, :model, :schema_modifier, :response + attr_reader :model_definition, :configuration, :model, :schema_modifier, :response def initialize(model_definition) @model_definition = model_definition diff --git a/lib/schemable/included_schema_generator.rb b/lib/schemable/included_schema_generator.rb index 6826e24..721a2d0 100644 --- a/lib/schemable/included_schema_generator.rb +++ b/lib/schemable/included_schema_generator.rb @@ -1,6 +1,6 @@ module Schemable class IncludedSchemaGenerator - attr_accessor :model_definition, :schema_modifier, :relationships + attr_reader :model_definition, :schema_modifier, :relationships def initialize(model_definition) @model_definition = model_definition diff --git a/lib/schemable/relationship_schema_generator.rb b/lib/schemable/relationship_schema_generator.rb index 383e5af..a39ffe3 100644 --- a/lib/schemable/relationship_schema_generator.rb +++ b/lib/schemable/relationship_schema_generator.rb @@ -1,6 +1,6 @@ module Schemable class RelationshipSchemaGenerator - attr_accessor :model_definition, :schema_modifier, :relationships + attr_reader :model_definition, :schema_modifier, :relationships def initialize(model_definition) @model_definition = model_definition diff --git a/lib/schemable/request_schema_generator.rb b/lib/schemable/request_schema_generator.rb index 5847530..ceb8cf8 100644 --- a/lib/schemable/request_schema_generator.rb +++ b/lib/schemable/request_schema_generator.rb @@ -1,6 +1,6 @@ module Schemable class RequestSchemaGenerator - attr_accessor :model_definition, :schema_modifier + attr_reader :model_definition, :schema_modifier def initialize(model_definition) @model_definition = model_definition diff --git a/lib/schemable/response_schema_generator.rb b/lib/schemable/response_schema_generator.rb index b29c5c0..c59464d 100644 --- a/lib/schemable/response_schema_generator.rb +++ b/lib/schemable/response_schema_generator.rb @@ -1,6 +1,6 @@ module Schemable class ResponseSchemaGenerator - attr_accessor :model_definition, :model + attr_reader :model_definition, :model, :schema_modifier def initialize(model_definition) @model_definition = model_definition diff --git a/sig/schemable/attribute_schema_generator.rbs b/sig/schemable/attribute_schema_generator.rbs index b321b5e..4b950b1 100644 --- a/sig/schemable/attribute_schema_generator.rbs +++ b/sig/schemable/attribute_schema_generator.rbs @@ -1,10 +1,10 @@ module Schemable class AttributeSchemaGenerator - attr_accessor model: Class - attr_accessor model_definition: Definition - attr_accessor configuration: Configuration - attr_accessor response: Hash[Symbol, any]? - attr_accessor schema_modifier: SchemaModifier + attr_reader model: Class + attr_reader model_definition: Definition + attr_reader configuration: Configuration + attr_reader response: Hash[Symbol, any]? + attr_reader schema_modifier: SchemaModifier def initialize: (Definition) -> void def generate: -> (Hash[Symbol, any] | Array[any]) diff --git a/sig/schemable/included_schema_generator.rbs b/sig/schemable/included_schema_generator.rbs index a090746..6677d99 100644 --- a/sig/schemable/included_schema_generator.rbs +++ b/sig/schemable/included_schema_generator.rbs @@ -1,11 +1,8 @@ module Schemable class IncludedSchemaGenerator - attr_accessor expand: bool - attr_accessor model_definition: Definition - attr_accessor configuration: Configuration - attr_accessor schema_modifier: SchemaModifier - attr_accessor relationships: Hash[Symbol, any] - attr_accessor relationships_to_exclude_from_expansion: Array[String] + attr_reader model_definition: Definition + attr_reader schema_modifier: SchemaModifier + attr_reader relationships: Hash[Symbol, any] def initialize: (Definition) -> void diff --git a/sig/schemable/relationship_schema_generator.rbs b/sig/schemable/relationship_schema_generator.rbs index 2e6a874..b82bcb1 100644 --- a/sig/schemable/relationship_schema_generator.rbs +++ b/sig/schemable/relationship_schema_generator.rbs @@ -1,8 +1,8 @@ module Schemable class RelationshipSchemaGenerator - attr_accessor model_definition: Definition - attr_accessor schema_modifier: SchemaModifier - attr_accessor relationships: Hash[Symbol, any] + attr_reader model_definition: Definition + attr_reader schema_modifier: SchemaModifier + attr_reader relationships: Hash[Symbol, any] def initialize: (Definition) -> void diff --git a/sig/schemable/request_schema_generator.rbs b/sig/schemable/request_schema_generator.rbs index 29f3996..c6a99b0 100644 --- a/sig/schemable/request_schema_generator.rbs +++ b/sig/schemable/request_schema_generator.rbs @@ -1,7 +1,7 @@ module Schemable class RequestSchemaGenerator - attr_accessor model_definition: Definition - attr_accessor schema_modifier: SchemaModifier + attr_reader model_definition: Definition + attr_reader schema_modifier: SchemaModifier def initialize: (Definition) -> void def generate_for_create: () -> (Hash[Symbol, any] | Array[Hash[Symbol, any]]) diff --git a/sig/schemable/response_schema_generator.rbs b/sig/schemable/response_schema_generator.rbs index f09bee5..22d45a2 100644 --- a/sig/schemable/response_schema_generator.rbs +++ b/sig/schemable/response_schema_generator.rbs @@ -1,8 +1,8 @@ module Schemable class ResponseSchemaGenerator - attr_accessor model: Class - attr_accessor model_definition: Definition - attr_accessor schema_modifier: SchemaModifier + attr_reader model: Class + attr_reader model_definition: Definition + attr_reader schema_modifier: SchemaModifier def initialize: (Definition) -> void def meta: -> Hash[Symbol, any]