ditkrg/rswag
4
0
Fork 0
mirror of https://github.com/ditkrg/rswag.git synced 2026-01-23 06:16:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

avoid metadata mutation in request_factory

Browse Source
This commit is contained in:
domaindrivendev 2018-04-23 16:00:00 -07:00
parent 12daacf9a5
commit 26a3bf5079
2 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rswag-specs/lib/rswag/specs/request_factory.rb
View File

@ -29,15 +29,11 @@ module Rswag
path_item_params = metadata[:path_item][:parameters] || [] path_item_params = metadata[:path_item][:parameters] || []
security_params = derive_security_params(metadata, swagger_doc) security_params = derive_security_params(metadata, swagger_doc)
operation_params = operation_params # NOTE: Use of + instead of concat to avoid mutation of the metadata object
.concat(path_item_params) (operation_params + path_item_params + security_params)
.concat(security_params)
.map { |p| p['$ref'] ? resolve_parameter(p['$ref'], swagger_doc) : p } .map { |p| p['$ref'] ? resolve_parameter(p['$ref'], swagger_doc) : p }
.uniq { |p| p[:name] } .uniq { |p| p[:name] }
.reject { |p| p[:required] == false && !example.respond_to?(p[:name]) } .reject { |p| p[:required] == false && !example.respond_to?(p[:name]) }
metadata[:operation][:parameters] = operation_params unless operation_params.empty?
operation_params
end end
def derive_security_params(metadata, swagger_doc) def derive_security_params(metadata, swagger_doc)

11
rswag-specs/spec/rswag/specs/request_factory_spec.rb
View File

@ -236,17 +236,6 @@ module Rswag
end end
end end
context 'in header with no other params' do
let(:key_location) { :header }
it 'adds name and example value to the headers' do
expect(request[:headers]).to eq('api_key' => 'foobar')
expect(metadata[:operation][:parameters]).to(
include(name: 'api_key', in: :header, type: :string, required: true)
)
end
end
context 'in header with auth param already added' do context 'in header with auth param already added' do
let(:key_location) { :header } let(:key_location) { :header }
before do before do