mirror of
https://github.com/ditkrg/idempotent-request.git
synced 2026-01-23 06:16:43 +00:00
4488a19f28
- fix an issue when getting an exception inside application would not delete lock, so client could receive 429 after 500
104 lines
3.2 KiB
Ruby
104 lines
3.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
RSpec.describe IdempotentRequest::Middleware do
|
|
let(:app) { -> (env) { [200, {}, 'body'] } }
|
|
let(:env) do
|
|
env_for('https://qonto.eu', method: 'POST')
|
|
.merge!(
|
|
'HTTP_X_QONTO_IDEMPOTENCY_KEY' => 'dont-repeat-this-request-pls'
|
|
)
|
|
end
|
|
let(:storage) { @memory_storage ||= IdempotentRequest::MemoryStorage.new }
|
|
let(:policy) do
|
|
class_double('IdempotentRequest::policy', new: double(should?: true))
|
|
end
|
|
|
|
let(:middleware) do
|
|
described_class.new(app,
|
|
policy: policy,
|
|
storage: storage,
|
|
header_key: 'X-Qonto-Idempotency-Key'
|
|
)
|
|
end
|
|
|
|
context 'when should be idempotent' do
|
|
it 'should be saved to storage' do
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:read)
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:write)
|
|
|
|
middleware.call(env)
|
|
end
|
|
|
|
it 'should obtain lock and release lock' do
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:lock).and_return(true)
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:write)
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:unlock)
|
|
|
|
middleware.call(env)
|
|
end
|
|
|
|
context 'when an exception happens inside another middleware' do
|
|
let(:app) { ->(_) { raise 'fatality' } }
|
|
|
|
it 'should release lock' do
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:lock).and_return(true)
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).not_to receive(:write)
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:unlock)
|
|
|
|
expect { middleware.call(env) }.to raise_error('fatality')
|
|
end
|
|
end
|
|
|
|
context 'when has data in storage' do
|
|
before do
|
|
data = [200, {}, 'body']
|
|
allow_any_instance_of(IdempotentRequest::RequestManager).to receive(:read).and_return(data)
|
|
end
|
|
|
|
it 'should read from storage' do
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:read)
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).not_to receive(:write)
|
|
|
|
middleware.call(env)
|
|
end
|
|
end
|
|
|
|
context 'when concurrent requests' do
|
|
before do
|
|
allow_any_instance_of(IdempotentRequest::RequestManager).to receive(:lock).and_return(false)
|
|
end
|
|
|
|
it 'should not return data from storage' do
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).to receive(:read).and_return(nil)
|
|
|
|
middleware.call(env)
|
|
end
|
|
|
|
it 'should not obtain lock' do
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).not_to receive(:write)
|
|
|
|
middleware.call(env)
|
|
end
|
|
|
|
it 'returns 429' do
|
|
expect_any_instance_of(described_class).to receive(:concurrent_request_response)
|
|
|
|
middleware.call(env)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when should not be idempotent' do
|
|
let(:policy) do
|
|
class_double('IdempotentRequest::policy', new: double(should?: false))
|
|
end
|
|
|
|
it 'should not read storage' do
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).not_to receive(:read)
|
|
expect_any_instance_of(IdempotentRequest::RequestManager).not_to receive(:write)
|
|
|
|
middleware.call(env)
|
|
end
|
|
end
|
|
end
|