From 517dc5c007340d355975bd73fa3c7770496b2ac0 Mon Sep 17 00:00:00 2001 From: Dmytro Zakharov Date: Mon, 22 Jan 2018 19:26:42 +0100 Subject: [PATCH] policy should be required --- lib/idempotent-request/middleware.rb | 8 ++++---- spec/idempotent-request/middleware_spec.rb | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/idempotent-request/middleware.rb b/lib/idempotent-request/middleware.rb index 82da1a9..cd0f0ba 100644 --- a/lib/idempotent-request/middleware.rb +++ b/lib/idempotent-request/middleware.rb @@ -3,7 +3,7 @@ module IdempotentRequest def initialize(app, config = {}) @app = app @config = config - @decider = config[:decider] + @policy = config.fetch(:policy) end def call(env) @@ -20,15 +20,15 @@ module IdempotentRequest private - attr_reader :app, :env, :config, :request, :decider + attr_reader :app, :env, :config, :request, :policy def process? !request.key.to_s.empty? && should_be_idempotent? end def should_be_idempotent? - return false unless decider - decider.new(request).should? + return false unless policy + policy.new(request).should? end def set_request(env) diff --git a/spec/idempotent-request/middleware_spec.rb b/spec/idempotent-request/middleware_spec.rb index 9e340cf..9efebf6 100644 --- a/spec/idempotent-request/middleware_spec.rb +++ b/spec/idempotent-request/middleware_spec.rb @@ -9,13 +9,13 @@ RSpec.describe IdempotentRequest::Middleware do ) end let(:storage) { @memory_storage ||= IdempotentRequest::MemoryStorage.new } - let(:decider) do - class_double('IdempotentRequest::Decider', new: double(should?: true)) + let(:policy) do + class_double('IdempotentRequest::policy', new: double(should?: true)) end let(:middleware) do described_class.new(app, - decider: decider, + policy: policy, storage: storage, header_key: 'X-Qonto-Idempotency-Key' ) @@ -45,8 +45,8 @@ RSpec.describe IdempotentRequest::Middleware do end context 'when should not be idempotent' do - let(:decider) do - class_double('IdempotentRequest::Decider', new: double(should?: false)) + let(:policy) do + class_double('IdempotentRequest::policy', new: double(should?: false)) end it 'should not read storage' do