From 850be8c3667ccc17050608dbae634cec8efb8b2a Mon Sep 17 00:00:00 2001 From: 5h4k4r <5h4k4r.b4kr@gmail.com> Date: Wed, 2 Nov 2022 12:02:16 +0300 Subject: [PATCH 1/3] Fix typographical errors --- docs/Discovery/documentationGuideline.md | 2 +- .../03-Distributed Computing Specifications/02-Deployment.md | 2 +- .../04-Race Conditions/04-Database Decisions.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/Discovery/documentationGuideline.md b/docs/Discovery/documentationGuideline.md index 54579c3..49ccd60 100644 --- a/docs/Discovery/documentationGuideline.md +++ b/docs/Discovery/documentationGuideline.md @@ -103,7 +103,7 @@ Example: |User Story #1| |---|-----| -|Who|Citize| +|Who|Citizen| |What|A citizen needs to attach their national ID to the form.| |Why|Because the auditor needs to check the identity of the citizen that filled the form.| |Priority|Must have| diff --git a/docs/Software Development/03-Distributed Computing Specifications/02-Deployment.md b/docs/Software Development/03-Distributed Computing Specifications/02-Deployment.md index 4c473a4..202caac 100644 --- a/docs/Software Development/03-Distributed Computing Specifications/02-Deployment.md +++ b/docs/Software Development/03-Distributed Computing Specifications/02-Deployment.md @@ -9,7 +9,7 @@ All software at DIT is packaged using Docker and will be running on Kubernetes. ## Dockerfile -The Dockerfile is a standard file that gives out instruction on how to build an image for the source code. Diffberent technology stacks have different base images on the top of which the new image is built. DIT has a local registry for all needed images. The base images used in this Dockerfile must be coming from our local registry. If the on-prem registry does not contain the base images that you need, speak to the Head of DevOps so that they are made available. If it is absolutely necessary to use an image that for some reasons cannot be hosted on our local registry, speak to the Head of DevOps to obtain approval. Otherwise, the change is considered a bug. +The Dockerfile is a standard file that gives out instruction on how to build an image for the source code. Different technology stacks have different base images on the top of which the new image is built. DIT has a local registry for all needed images. The base images used in this Dockerfile must be coming from our local registry. If the on-prem registry does not contain the base images that you need, speak to the Head of DevOps so that they are made available. If it is absolutely necessary to use an image that for some reasons cannot be hosted on our local registry, speak to the Head of DevOps to obtain approval. Otherwise, the change is considered a bug. See also: [Dockerfile reference](https://docs.docker.com/engine/reference/builder/) diff --git a/docs/Software Development/03-Distributed Computing Specifications/04-Race Conditions/04-Database Decisions.md b/docs/Software Development/03-Distributed Computing Specifications/04-Race Conditions/04-Database Decisions.md index 988edb0..ee3b762 100644 --- a/docs/Software Development/03-Distributed Computing Specifications/04-Race Conditions/04-Database Decisions.md +++ b/docs/Software Development/03-Distributed Computing Specifications/04-Race Conditions/04-Database Decisions.md @@ -6,6 +6,6 @@ Always place a unique index on columns are that supposed to contain unique value ## Versioning -It is always a good practice to version records so that is can also comply with the Optimistic Concurrency Control model. This requirement is not forced but it is highly recommended. +It is always a good practice to version records so that they can also comply with the Optimistic Concurrency Control model. This requirement is not forced but it is highly recommended. The version column must be atomically incremented. \ No newline at end of file From c02acab0a79651fddf412a72bef2901848998e12 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 18 Nov 2022 01:07:19 +0000 Subject: [PATCH 2/3] Bump imranismail/setup-kustomize from 1 to 2 Bumps [imranismail/setup-kustomize](https://github.com/imranismail/setup-kustomize) from 1 to 2. - [Release notes](https://github.com/imranismail/setup-kustomize/releases) - [Commits](https://github.com/imranismail/setup-kustomize/compare/v1...v2) --- updated-dependencies: - dependency-name: imranismail/setup-kustomize dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/deploy-base.yaml | 2 +- .github/workflows/tests-base.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy-base.yaml b/.github/workflows/deploy-base.yaml index 902813c..6b7744f 100644 --- a/.github/workflows/deploy-base.yaml +++ b/.github/workflows/deploy-base.yaml @@ -40,7 +40,7 @@ jobs: kubeconfig: ${{ secrets.KUBECONFIG }} - name: Setup Kustomize - uses: imranismail/setup-kustomize@v1 + uses: imranismail/setup-kustomize@v2 - name: Edit kustomization file working-directory: kubernetes/base diff --git a/.github/workflows/tests-base.yaml b/.github/workflows/tests-base.yaml index 5ea6033..caa8a93 100644 --- a/.github/workflows/tests-base.yaml +++ b/.github/workflows/tests-base.yaml @@ -27,7 +27,7 @@ jobs: uses: Azure/setup-kubectl@v3 - name: Setup Kustomize - uses: imranismail/setup-kustomize@v1 + uses: imranismail/setup-kustomize@v2 - name: Build k8s manifests working-directory: kubernetes From f33658fca584965db1a30de50f28045a135d9d35 Mon Sep 17 00:00:00 2001 From: Brusk Awat Date: Sun, 12 Mar 2023 16:08:10 +0300 Subject: [PATCH 3/3] Updates Annex 2 --- .../09-Checklist For Microservices.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/Software Development/04-Software Application Specifications/09-Checklist For Microservices.md b/docs/Software Development/04-Software Application Specifications/09-Checklist For Microservices.md index 781bfff..ae7c340 100644 --- a/docs/Software Development/04-Software Application Specifications/09-Checklist For Microservices.md +++ b/docs/Software Development/04-Software Application Specifications/09-Checklist For Microservices.md @@ -40,11 +40,11 @@ Use the following checklist when dealing with a microservices architecture inter ```JSON { meta: { - page: { + pagination: { totalPages: "integer" count: "integer", - limitValue: "integer", - currentPage: "integer" + rowsPerPage: "integer", + page: "integer" } } }