mirror of
https://github.com/ditkrg/active_model_serializers.git
synced 2026-01-23 22:36:50 +00:00
* Remove appveyor rubygems/bundler stuff * Try specifying different jdbc adapter * Attempt to fix failing JRuby test I cannot reproduce ``` bundle exec rake ci Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m /home/travis/.rvm/rubies/jruby-9.1.9.0/bin/jruby -w -I"lib:lib:test" -r./test/test_helper.rb -w -I"/home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/rake-11.3.0/lib" "/home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/rake-11.3.0/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" ActiveModelSerializers::Adapter::JsonApi::PaginationLinksTest#test_raises_descriptive_error_when_serialization_context_unset [/home/travis/build/rails-api/active_model_serializers/test/adapter/json_api/pagination_links_test.rb:186]: [] exception expected, not Class: <ActiveModelSerializers::Adapter::JsonApi::PaginationLinks::MissingSerializationContextError> Message: <" JsonApi::PaginationLinks requires a ActiveModelSerializers::SerializationContext.\n Please pass a ':serialization_context' option or\n override CollectionSerializer#paginated? to return 'false'.\n"> ---Backtrace--- /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/adapter/json_api/pagination_links.rb:14:in `block in initialize' org/jruby/RubyHash.java:1187:in `fetch' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/adapter/json_api/pagination_links.rb:13:in `initialize' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/adapter/json_api.rb:520:in `pagination_links_for' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/adapter/json_api.rb:147:in `success_document' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/adapter/json_api.rb:59:in `serializable_hash' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/adapter/base.rb:59:in `as_json' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/serializable_resource.rb:8:in `as_json' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:69:in `block in as_json' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:117:in `call' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:555:in `block in compile' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:505:in `call' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:498:in `block in around' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:343:in `block in simple' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:22:in `block in instrument_rendering' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:79:in `block in notify_render' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/notifications.rb:164:in `block in instrument' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/notifications/instrumenter.rb:20:in `instrument' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/notifications.rb:164:in `instrument' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:78:in `notify_render' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:21:in `block in instrument_rendering' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:97:in `tag_logger' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:20:in `block in instrument_rendering' org/jruby/RubyBasicObject.java:1724:in `instance_exec' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:441:in `block in make_lambda' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:342:in `block in simple' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:497:in `block in around' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:505:in `call' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:92:in `__run_callbacks__' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:778:in `_run_render_callbacks' /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:81:in `run_callbacks' /home/travis/build/rails-api/active_model_serializers/lib/active_model_serializers/logging.rb:68:in `block in as_json' /home/travis/build/rails-api/active_model_serializers/test/adapter/json_api/pagination_links_test.rb:187:in `block in test_raises_descriptive_error_when_serialization_context_unset' Command failed with status (1): [ruby -w -I"lib:lib:test" -r./test/test_helper.rb -w -I"/home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/rake-11.3.0/lib" "/home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/rake-11.3.0/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" ] /home/travis/build/rails-api/active_model_serializers/vendor/bundle/jruby/2.3.0/gems/rake-11.3.0/exe/rake:27:in `<main>' Tasks: TOP => ci => default => test (See full trace by running task with --trace) ```
207 lines
7.4 KiB
Ruby
207 lines
7.4 KiB
Ruby
require 'test_helper'
|
|
require 'will_paginate/array'
|
|
require 'kaminari'
|
|
require 'kaminari/hooks'
|
|
::Kaminari::Hooks.init
|
|
|
|
module ActiveModelSerializers
|
|
module Adapter
|
|
class JsonApi
|
|
class PaginationLinksTest < ActiveSupport::TestCase
|
|
URI = 'http://example.com'.freeze
|
|
|
|
def setup
|
|
ActionController::Base.cache_store.clear
|
|
@array = [
|
|
Profile.new(id: 1, name: 'Name 1', description: 'Description 1', comments: 'Comments 1'),
|
|
Profile.new(id: 2, name: 'Name 2', description: 'Description 2', comments: 'Comments 2'),
|
|
Profile.new(id: 3, name: 'Name 3', description: 'Description 3', comments: 'Comments 3'),
|
|
Profile.new(id: 4, name: 'Name 4', description: 'Description 4', comments: 'Comments 4'),
|
|
Profile.new(id: 5, name: 'Name 5', description: 'Description 5', comments: 'Comments 5')
|
|
]
|
|
end
|
|
|
|
def mock_request(query_parameters = {}, original_url = URI)
|
|
context = Minitest::Mock.new
|
|
context.expect(:request_url, original_url)
|
|
context.expect(:query_parameters, query_parameters)
|
|
context.expect(:key_transform, nil)
|
|
end
|
|
|
|
def load_adapter(paginated_collection, mock_request = nil)
|
|
render_options = { adapter: :json_api }
|
|
render_options[:serialization_context] = mock_request if mock_request
|
|
serializable(paginated_collection, render_options)
|
|
end
|
|
|
|
def using_kaminari(page = 2)
|
|
Kaminari.paginate_array(@array).page(page).per(2)
|
|
end
|
|
|
|
def using_will_paginate(page = 2)
|
|
@array.paginate(page: page, per_page: 2)
|
|
end
|
|
|
|
def data
|
|
{
|
|
data: [
|
|
{ id: '1', type: 'profiles', attributes: { name: 'Name 1', description: 'Description 1' } },
|
|
{ id: '2', type: 'profiles', attributes: { name: 'Name 2', description: 'Description 2' } },
|
|
{ id: '3', type: 'profiles', attributes: { name: 'Name 3', description: 'Description 3' } },
|
|
{ id: '4', type: 'profiles', attributes: { name: 'Name 4', description: 'Description 4' } },
|
|
{ id: '5', type: 'profiles', attributes: { name: 'Name 5', description: 'Description 5' } }
|
|
]
|
|
}
|
|
end
|
|
|
|
def empty_collection_links
|
|
{
|
|
self: "#{URI}?page%5Bnumber%5D=1&page%5Bsize%5D=2",
|
|
first: "#{URI}?page%5Bnumber%5D=1&page%5Bsize%5D=2",
|
|
prev: nil,
|
|
next: nil,
|
|
last: "#{URI}?page%5Bnumber%5D=1&page%5Bsize%5D=2"
|
|
}
|
|
end
|
|
|
|
def links
|
|
{
|
|
links: {
|
|
self: "#{URI}?page%5Bnumber%5D=2&page%5Bsize%5D=2",
|
|
first: "#{URI}?page%5Bnumber%5D=1&page%5Bsize%5D=2",
|
|
prev: "#{URI}?page%5Bnumber%5D=1&page%5Bsize%5D=2",
|
|
next: "#{URI}?page%5Bnumber%5D=3&page%5Bsize%5D=2",
|
|
last: "#{URI}?page%5Bnumber%5D=3&page%5Bsize%5D=2"
|
|
}
|
|
}
|
|
end
|
|
|
|
def last_page_links
|
|
{
|
|
links: {
|
|
self: "#{URI}?page%5Bnumber%5D=3&page%5Bsize%5D=2",
|
|
first: "#{URI}?page%5Bnumber%5D=1&page%5Bsize%5D=2",
|
|
prev: "#{URI}?page%5Bnumber%5D=2&page%5Bsize%5D=2",
|
|
next: nil,
|
|
last: "#{URI}?page%5Bnumber%5D=3&page%5Bsize%5D=2"
|
|
}
|
|
}
|
|
end
|
|
|
|
def expected_response_when_unpaginatable
|
|
data
|
|
end
|
|
|
|
def expected_response_with_pagination_links
|
|
{}.tap do |hash|
|
|
hash[:data] = data.values.flatten[2..3]
|
|
hash.merge! links
|
|
end
|
|
end
|
|
|
|
def expected_response_without_pagination_links
|
|
{}.tap do |hash|
|
|
hash[:data] = data.values.flatten[2..3]
|
|
end
|
|
end
|
|
|
|
def expected_response_with_pagination_links_and_additional_params
|
|
new_links = links[:links].each_with_object({}) { |(key, value), hash| hash[key] = "#{value}&test=test" }
|
|
{}.tap do |hash|
|
|
hash[:data] = data.values.flatten[2..3]
|
|
hash.merge! links: new_links
|
|
end
|
|
end
|
|
|
|
def expected_response_with_last_page_pagination_links
|
|
{}.tap do |hash|
|
|
hash[:data] = [data.values.flatten.last]
|
|
hash.merge! last_page_links
|
|
end
|
|
end
|
|
|
|
def expected_response_with_empty_collection_pagination_links
|
|
{}.tap do |hash|
|
|
hash[:data] = []
|
|
hash.merge! links: empty_collection_links
|
|
end
|
|
end
|
|
|
|
def test_pagination_links_using_kaminari
|
|
adapter = load_adapter(using_kaminari, mock_request)
|
|
|
|
assert_equal expected_response_with_pagination_links, adapter.serializable_hash
|
|
end
|
|
|
|
def test_pagination_links_using_will_paginate
|
|
adapter = load_adapter(using_will_paginate, mock_request)
|
|
|
|
assert_equal expected_response_with_pagination_links, adapter.serializable_hash
|
|
end
|
|
|
|
def test_pagination_links_with_additional_params
|
|
adapter = load_adapter(using_will_paginate, mock_request(test: 'test'))
|
|
|
|
assert_equal expected_response_with_pagination_links_and_additional_params,
|
|
adapter.serializable_hash
|
|
end
|
|
|
|
def test_pagination_links_when_zero_results_kaminari
|
|
@array = []
|
|
|
|
adapter = load_adapter(using_kaminari(1), mock_request)
|
|
|
|
assert_equal expected_response_with_empty_collection_pagination_links, adapter.serializable_hash
|
|
end
|
|
|
|
def test_pagination_links_when_zero_results_will_paginate
|
|
@array = []
|
|
|
|
adapter = load_adapter(using_will_paginate(1), mock_request)
|
|
|
|
assert_equal expected_response_with_empty_collection_pagination_links, adapter.serializable_hash
|
|
end
|
|
|
|
def test_last_page_pagination_links_using_kaminari
|
|
adapter = load_adapter(using_kaminari(3), mock_request)
|
|
|
|
assert_equal expected_response_with_last_page_pagination_links, adapter.serializable_hash
|
|
end
|
|
|
|
def test_last_page_pagination_links_using_will_paginate
|
|
adapter = load_adapter(using_will_paginate(3), mock_request)
|
|
|
|
assert_equal expected_response_with_last_page_pagination_links, adapter.serializable_hash
|
|
end
|
|
|
|
def test_not_showing_pagination_links
|
|
adapter = load_adapter(@array, mock_request)
|
|
|
|
assert_equal expected_response_when_unpaginatable, adapter.serializable_hash
|
|
end
|
|
|
|
def test_raises_descriptive_error_when_serialization_context_unset
|
|
render_options = { adapter: :json_api }
|
|
adapter = serializable(using_kaminari, render_options)
|
|
exception_class = ActiveModelSerializers::Adapter::JsonApi::PaginationLinks::MissingSerializationContextError
|
|
|
|
exception = assert_raises(exception_class) do
|
|
adapter.as_json
|
|
end
|
|
assert_equal exception_class, exception.class
|
|
assert_match(/CollectionSerializer#paginated\?/, exception.message)
|
|
end
|
|
|
|
def test_pagination_links_not_present_when_disabled
|
|
ActiveModel::Serializer.config.jsonapi_pagination_links_enabled = false
|
|
adapter = load_adapter(using_kaminari, mock_request)
|
|
|
|
assert_equal expected_response_without_pagination_links, adapter.serializable_hash
|
|
ensure
|
|
ActiveModel::Serializer.config.jsonapi_pagination_links_enabled = true
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|