mirror of
https://github.com/ditkrg/active_model_serializers.git
synced 2026-01-23 22:36:50 +00:00
* Set up GitHub actions CI * Remove simplecov entirely for now * Fix deprecations * Relax dev deps * Address Rails 6.0 blocking hosts * Rails 6.1 content type changed to application/json; charset=utf-8 * Test a few more rubies and rails * Stop testing grape. We should drop grape support ``` /home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.6.0/gems/grape-0.19.0/lib/grape/error_formatter.rb:16: warning: in `formatters': the last argument was passed as a single Hash /home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.6.0/gems/grape-0.19.0/lib/grape/error_formatter.rb:21: warning: although a splat keyword arguments here Run options: --seed 23470 ..........................................................................................................................................................................................................................................................................................................................................................................................................................................E ActiveModelSerializers::GrapeTest#test_render_helper_passes_through_options_correctly: NoMethodError: undefined method `[]' for nil:NilClass bin/rails test /home/runner/work/active_model_serializers/active_model_serializers/test/grape_test.rb:126 W, [2020-12-29T02:27:48.991413 #2790] WARN -- : You are setting a key that conflicts with a built-in method Hashie::Mash#size defined in Hash. This can cause unexpected behavior when accessing the key as a property. You can still access the key via the #[] method. W, [2020-12-29T02:27:48.991505 #2790] WARN -- : You are setting a key that conflicts with a built-in method Hashie::Mash#size defined in Hash. This can cause unexpected behavior when accessing the key as a property. You can still access the key via the #[] method. W, [2020-12-29T02:27:48.991581 #2790] WARN -- : You are setting a key that conflicts with a built-in method Hashie::Mash#size defined in Hash. This can cause unexpected behavior when accessing the key as a property. You can still access the key via the #[] method. W, [2020-12-29T02:27:48.991625 #2790] WARN -- : You are setting a key that conflicts with a built-in method Hashie::Mash#size defined in Hash. This can cause unexpected behavior when accessing the key as a property. You can still access the key via the #[] method. E Error: ActiveModelSerializers::GrapeTest#test_implicit_formatter_handles_collections: NoMethodError: undefined method `[]' for nil:NilClass bin/rails test /home/runner/work/active_model_serializers/active_model_serializers/test/grape_test.rb:185 ............................................................................................................................................... Finished in 2.052241s, 280.6688 runs/s, 473.6285 assertions/s. 576 runs, 972 assertions, 0 failures, 7 errors, 0 skips rake aborted! Command failed with status (1): [ruby -w -I"lib:lib:test" -r./test/test_helper.rb -w -I"/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.6.0/gems/rake-12.3.3/lib" "/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.6.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb" "test/action_controller/adapter_selector_test.rb" "test/action_controller/explicit_serializer_test.rb" "test/action_controller/json/include_test.rb" "test/action_controller/json_api/deserialization_test.rb" "test/action_controller/json_api/errors_test.rb" "test/action_controller/json_api/fields_test.rb" "test/action_controller/json_api/linked_test.rb" "test/action_controller/json_api/pagination_test.rb" "test/action_controller/json_api/transform_test.rb" "test/action_controller/lookup_proc_test.rb" "test/action_controller/namespace_lookup_test.rb" "test/action_controller/serialization_scope_name_test.rb" "test/action_controller/serialization_test.rb" "test/active_model_serializers/adapter_for_test.rb" "test/active_model_serializers/json_pointer_test.rb" "test/active_model_serializers/logging_test.rb" "test/active_model_serializers/model_test.rb" "test/active_model_serializers/test/schema_test.rb" "test/active_model_serializers/test/serializer_test.rb" "test/active_record_test.rb" "test/adapter/attributes_test.rb" "test/adapter/deprecation_test.rb" "test/adapter/json/belongs_to_test.rb" "test/adapter/json/collection_test.rb" "test/adapter/json/fields_test.rb" "test/adapter/json/has_many_test.rb" "test/adapter/json/transform_test.rb" "test/adapter/json_api/belongs_to_test.rb" "test/adapter/json_api/collection_test.rb" "test/adapter/json_api/errors_test.rb" "test/adapter/json_api/fields_test.rb" "test/adapter/json_api/has_many_explicit_serializer_test.rb" "test/adapter/json_api/has_many_test.rb" "test/adapter/json_api/has_one_test.rb" "test/adapter/json_api/include_data_if_sideloaded_test.rb" "test/adapter/json_api/json_api_test.rb" "test/adapter/json_api/linked_test.rb" "test/adapter/json_api/links_test.rb" "test/adapter/json_api/pagination_links_test.rb" "test/adapter/json_api/parse_test.rb" "test/adapter/json_api/relationship_test.rb" "test/adapter/json_api/resource_meta_test.rb" "test/adapter/json_api/toplevel_jsonapi_test.rb" "test/adapter/json_api/transform_test.rb" "test/adapter/json_api/type_test.rb" "test/adapter/json_test.rb" "test/adapter/null_test.rb" "test/adapter/polymorphic_test.rb" "test/adapter_test.rb" "test/array_serializer_test.rb" "test/cache_test.rb" "test/collection_serializer_test.rb" "test/generators/scaffold_controller_generator_test.rb" "test/generators/serializer_generator_test.rb" "test/grape_test.rb" "test/lint_test.rb" "test/logger_test.rb" "test/poro_test.rb" "test/serializable_resource_test.rb" "test/serializers/association_macros_test.rb" "test/serializers/associations_test.rb" "test/serializers/attribute_test.rb" "test/serializers/attributes_test.rb" "test/serializers/configuration_test.rb" "test/serializers/fieldset_test.rb" "test/serializers/meta_test.rb" "test/serializers/options_test.rb" "test/serializers/read_attribute_for_serialization_test.rb" "test/serializers/reflection_test.rb" "test/serializers/root_test.rb" "test/serializers/serialization_test.rb" "test/serializers/serializer_for_test.rb" "test/serializers/serializer_for_with_namespace_test.rb" ] /home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.6.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' /opt/hostedtoolcache/Ruby/2.6.6/x64/bin/bundle:23:in `load' /opt/hostedtoolcache/Ruby/2.6.6/x64/bin/bundle:23:in `<main>' Tasks: TOP => default => test (See full trace by running task with --trace) Error: Process completed with exit code 1. ```
481 lines
15 KiB
Ruby
481 lines
15 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'test_helper'
|
|
|
|
module ActionController
|
|
module Serialization
|
|
class ImplicitSerializerTest < ActionController::TestCase
|
|
class ImplicitSerializationTestController < ActionController::Base
|
|
include SerializationTesting
|
|
def render_using_implicit_serializer
|
|
@profile = Profile.new(name: 'Name 1', description: 'Description 1', comments: 'Comments 1')
|
|
render json: @profile
|
|
end
|
|
|
|
def render_using_default_adapter_root
|
|
@profile = Profile.new(name: 'Name 1', description: 'Description 1', comments: 'Comments 1')
|
|
render json: @profile
|
|
end
|
|
|
|
def render_array_using_custom_root
|
|
@profile = Profile.new(name: 'Name 1', description: 'Description 1', comments: 'Comments 1')
|
|
render json: [@profile], root: 'custom_root'
|
|
end
|
|
|
|
def render_array_that_is_empty_using_custom_root
|
|
render json: [], root: 'custom_root'
|
|
end
|
|
|
|
def render_object_using_custom_root
|
|
@profile = Profile.new(name: 'Name 1', description: 'Description 1', comments: 'Comments 1')
|
|
render json: @profile, root: 'custom_root'
|
|
end
|
|
|
|
def render_array_using_implicit_serializer
|
|
array = [
|
|
Profile.new(name: 'Name 1', description: 'Description 1', comments: 'Comments 1'),
|
|
Profile.new(name: 'Name 2', description: 'Description 2', comments: 'Comments 2')
|
|
]
|
|
render json: array
|
|
end
|
|
|
|
def render_array_using_implicit_serializer_and_meta
|
|
@profiles = [
|
|
Profile.new(name: 'Name 1', description: 'Description 1', comments: 'Comments 1')
|
|
]
|
|
render json: @profiles, meta: { total: 10 }
|
|
end
|
|
|
|
def render_array_using_implicit_serializer_and_links
|
|
with_adapter ActiveModelSerializers::Adapter::JsonApi do
|
|
@profiles = [
|
|
Profile.new(name: 'Name 1', description: 'Description 1', comments: 'Comments 1')
|
|
]
|
|
|
|
render json: @profiles, links: { self: 'http://example.com/api/profiles/1' }
|
|
end
|
|
end
|
|
|
|
def render_object_with_cache_enabled
|
|
@comment = Comment.new(id: 1, body: 'ZOMG A COMMENT')
|
|
@author = Author.new(id: 1, name: 'Joao Moura.')
|
|
@post = Post.new(id: 1, title: 'New Post', body: 'Body', comments: [@comment], author: @author)
|
|
|
|
generate_cached_serializer(@post)
|
|
|
|
@post.title = 'ZOMG a New Post'
|
|
render json: @post
|
|
end
|
|
|
|
def render_json_object_without_serializer
|
|
render json: { error: 'Result is Invalid' }
|
|
end
|
|
|
|
def render_json_array_object_without_serializer
|
|
render json: [{ error: 'Result is Invalid' }]
|
|
end
|
|
|
|
def update_and_render_object_with_cache_enabled
|
|
@post.updated_at = Time.zone.now
|
|
|
|
generate_cached_serializer(@post)
|
|
render json: @post
|
|
end
|
|
|
|
def render_object_expired_with_cache_enabled
|
|
comment = Comment.new(id: 1, body: 'ZOMG A COMMENT')
|
|
author = Author.new(id: 1, name: 'Joao Moura.')
|
|
post = Post.new(id: 1, title: 'New Post', body: 'Body', comments: [comment], author: author)
|
|
|
|
generate_cached_serializer(post)
|
|
|
|
post.title = 'ZOMG a New Post'
|
|
|
|
expires_in = [
|
|
PostSerializer._cache_options[:expires_in],
|
|
CommentSerializer._cache_options[:expires_in]
|
|
].max + 200
|
|
|
|
Timecop.travel(Time.zone.now + expires_in) do
|
|
render json: post
|
|
end
|
|
end
|
|
|
|
def render_changed_object_with_cache_enabled
|
|
comment = Comment.new(id: 1, body: 'ZOMG A COMMENT')
|
|
author = Author.new(id: 1, name: 'Joao Moura.')
|
|
post = Post.new(id: 1, title: 'ZOMG a New Post', body: 'Body', comments: [comment], author: author)
|
|
|
|
render json: post
|
|
end
|
|
|
|
def render_fragment_changed_object_with_only_cache_enabled
|
|
author = Author.new(id: 1, name: 'Joao Moura.')
|
|
role = Role.new(id: 42, name: 'ZOMG A ROLE', description: 'DESCRIPTION HERE', author: author)
|
|
|
|
generate_cached_serializer(role)
|
|
role.name = 'lol'
|
|
role.description = 'HUEHUEBRBR'
|
|
|
|
render json: role
|
|
end
|
|
|
|
def render_fragment_changed_object_with_except_cache_enabled
|
|
author = Author.new(id: 1, name: 'Joao Moura.')
|
|
bio = Bio.new(id: 42, content: 'ZOMG A ROLE', rating: 5, author: author)
|
|
|
|
generate_cached_serializer(bio)
|
|
bio.content = 'lol'
|
|
bio.rating = 0
|
|
|
|
render json: bio
|
|
end
|
|
|
|
def render_fragment_changed_object_with_relationship
|
|
comment = Comment.new(id: 1, body: 'ZOMG A COMMENT')
|
|
comment2 = Comment.new(id: 1, body: 'ZOMG AN UPDATED-BUT-NOT-CACHE-EXPIRED COMMENT')
|
|
like = Like.new(id: 1, likeable: comment, time: 3.days.ago)
|
|
|
|
generate_cached_serializer(like)
|
|
like.likeable = comment2
|
|
like.time = Time.zone.now.to_s
|
|
|
|
render json: like
|
|
end
|
|
end
|
|
|
|
tests ImplicitSerializationTestController
|
|
|
|
# We just have Null for now, this will change
|
|
def test_render_using_implicit_serializer
|
|
get :render_using_implicit_serializer
|
|
|
|
expected = {
|
|
name: 'Name 1',
|
|
description: 'Description 1'
|
|
}
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_using_default_root
|
|
with_adapter :json_api do
|
|
get :render_using_default_adapter_root
|
|
end
|
|
expected = {
|
|
data: {
|
|
id: @controller.instance_variable_get(:@profile).id.to_s,
|
|
type: 'profiles',
|
|
attributes: {
|
|
name: 'Name 1',
|
|
description: 'Description 1'
|
|
}
|
|
}
|
|
}
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_array_using_custom_root
|
|
with_adapter :json do
|
|
get :render_array_using_custom_root
|
|
end
|
|
expected = { custom_root: [{ name: 'Name 1', description: 'Description 1' }] }
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_array_that_is_empty_using_custom_root
|
|
with_adapter :json do
|
|
get :render_array_that_is_empty_using_custom_root
|
|
end
|
|
|
|
expected = { custom_root: [] }
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_object_using_custom_root
|
|
with_adapter :json do
|
|
get :render_object_using_custom_root
|
|
end
|
|
|
|
expected = { custom_root: { name: 'Name 1', description: 'Description 1' } }
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_json_object_without_serializer
|
|
get :render_json_object_without_serializer
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
expected_body = { error: 'Result is Invalid' }
|
|
assert_equal expected_body.to_json, @response.body
|
|
end
|
|
|
|
def test_render_json_array_object_without_serializer
|
|
get :render_json_array_object_without_serializer
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
expected_body = [{ error: 'Result is Invalid' }]
|
|
assert_equal expected_body.to_json, @response.body
|
|
end
|
|
|
|
def test_render_array_using_implicit_serializer
|
|
get :render_array_using_implicit_serializer
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
|
|
expected = [
|
|
{
|
|
name: 'Name 1',
|
|
description: 'Description 1'
|
|
},
|
|
{
|
|
name: 'Name 2',
|
|
description: 'Description 2'
|
|
}
|
|
]
|
|
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_array_using_implicit_serializer_and_meta
|
|
with_adapter :json_api do
|
|
get :render_array_using_implicit_serializer_and_meta
|
|
end
|
|
expected = {
|
|
data: [
|
|
{
|
|
id: @controller.instance_variable_get(:@profiles).first.id.to_s,
|
|
type: 'profiles',
|
|
attributes: {
|
|
name: 'Name 1',
|
|
description: 'Description 1'
|
|
}
|
|
}
|
|
],
|
|
meta: {
|
|
total: 10
|
|
}
|
|
}
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_array_using_implicit_serializer_and_links
|
|
get :render_array_using_implicit_serializer_and_links
|
|
|
|
expected = {
|
|
data: [
|
|
{
|
|
id: @controller.instance_variable_get(:@profiles).first.id.to_s,
|
|
type: 'profiles',
|
|
attributes: {
|
|
name: 'Name 1',
|
|
description: 'Description 1'
|
|
}
|
|
}
|
|
],
|
|
links: {
|
|
self: 'http://example.com/api/profiles/1'
|
|
}
|
|
}
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_with_cache_enable
|
|
expected = {
|
|
id: 1,
|
|
title: 'New Post',
|
|
body: 'Body',
|
|
comments: [
|
|
{
|
|
id: 1,
|
|
body: 'ZOMG A COMMENT'
|
|
}
|
|
],
|
|
blog: {
|
|
id: 999,
|
|
name: 'Custom blog'
|
|
},
|
|
author: {
|
|
id: 1,
|
|
name: 'Joao Moura.'
|
|
}
|
|
}
|
|
|
|
ActionController::Base.cache_store.clear
|
|
Timecop.freeze(Time.zone.now) do
|
|
get :render_object_with_cache_enabled
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected.to_json, @response.body
|
|
|
|
get :render_changed_object_with_cache_enabled
|
|
assert_equal expected.to_json, @response.body
|
|
end
|
|
|
|
ActionController::Base.cache_store.clear
|
|
get :render_changed_object_with_cache_enabled
|
|
assert_not_equal expected.to_json, @response.body
|
|
end
|
|
|
|
def test_render_with_cache_enable_and_expired
|
|
ActionController::Base.cache_store.clear
|
|
get :render_object_expired_with_cache_enabled
|
|
|
|
expected = {
|
|
id: 1,
|
|
title: 'ZOMG a New Post',
|
|
body: 'Body',
|
|
comments: [
|
|
{
|
|
id: 1,
|
|
body: 'ZOMG A COMMENT'
|
|
}
|
|
],
|
|
blog: {
|
|
id: 999,
|
|
name: 'Custom blog'
|
|
},
|
|
author: {
|
|
id: 1,
|
|
name: 'Joao Moura.'
|
|
}
|
|
}
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
actual = @response.body
|
|
expected = expected.to_json
|
|
if ENV['APPVEYOR'] && actual != expected
|
|
skip('Cache expiration tests sometimes fail on Appveyor. FIXME :)')
|
|
else
|
|
assert_equal actual, expected
|
|
end
|
|
end
|
|
|
|
def test_render_with_fragment_only_cache_enable
|
|
ActionController::Base.cache_store.clear
|
|
get :render_fragment_changed_object_with_only_cache_enabled
|
|
response = JSON.parse(@response.body)
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal 'ZOMG A ROLE', response['name']
|
|
assert_equal 'HUEHUEBRBR', response['description']
|
|
end
|
|
|
|
def test_render_with_fragment_except_cache_enable
|
|
ActionController::Base.cache_store.clear
|
|
get :render_fragment_changed_object_with_except_cache_enabled
|
|
response = JSON.parse(@response.body)
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal 5, response['rating']
|
|
assert_equal 'lol', response['content']
|
|
end
|
|
|
|
def test_render_fragment_changed_object_with_relationship
|
|
ActionController::Base.cache_store.clear
|
|
|
|
Timecop.freeze(Time.zone.now) do
|
|
get :render_fragment_changed_object_with_relationship
|
|
response = JSON.parse(@response.body)
|
|
|
|
expected_return = {
|
|
'id' => 1,
|
|
'time' => Time.zone.now.to_s,
|
|
'likeable' => {
|
|
'id' => 1,
|
|
'body' => 'ZOMG A COMMENT'
|
|
}
|
|
}
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
assert_equal expected_return, response
|
|
end
|
|
end
|
|
|
|
def test_cache_expiration_on_update
|
|
ActionController::Base.cache_store.clear
|
|
get :render_object_with_cache_enabled
|
|
|
|
expected = {
|
|
id: 1,
|
|
title: 'ZOMG a New Post',
|
|
body: 'Body',
|
|
comments: [
|
|
{
|
|
id: 1,
|
|
body: 'ZOMG A COMMENT'
|
|
}
|
|
],
|
|
blog: {
|
|
id: 999,
|
|
name: 'Custom blog'
|
|
},
|
|
author: {
|
|
id: 1,
|
|
name: 'Joao Moura.'
|
|
}
|
|
}
|
|
|
|
get :update_and_render_object_with_cache_enabled
|
|
|
|
assert_match(%r{\Aapplication/json}, @response.content_type)
|
|
actual = @response.body
|
|
expected = expected.to_json
|
|
if ENV['APPVEYOR'] && actual != expected
|
|
skip('Cache expiration tests sometimes fail on Appveyor. FIXME :)')
|
|
else
|
|
assert_equal actual, expected
|
|
end
|
|
end
|
|
|
|
def test_warn_overridding_use_adapter_as_falsy_on_controller_instance
|
|
controller = Class.new(ImplicitSerializationTestController) do
|
|
def use_adapter?
|
|
false
|
|
end
|
|
end.new
|
|
assert_output(nil, /adapter: false/) do
|
|
controller.get_serializer(Profile.new)
|
|
end
|
|
end
|
|
|
|
def test_dont_warn_overridding_use_adapter_as_truthy_on_controller_instance
|
|
controller = Class.new(ImplicitSerializationTestController) do
|
|
def use_adapter?
|
|
true
|
|
end
|
|
end.new
|
|
assert_output(nil, '') do
|
|
controller.get_serializer(Profile.new)
|
|
end
|
|
end
|
|
|
|
def test_render_event_is_emitted
|
|
subscriber = ::ActiveSupport::Notifications.subscribe('render.active_model_serializers') do |subscribed_event|
|
|
@subscribed_event = subscribed_event
|
|
end
|
|
|
|
get :render_using_implicit_serializer
|
|
|
|
subscribed_event_name =
|
|
if @subscribed_event.is_a?(String)
|
|
@subscribed_event
|
|
else
|
|
@subscribed_event.name # is a ActiveSupport::Notifications::Event
|
|
end
|
|
assert_equal 'render.active_model_serializers', subscribed_event_name
|
|
ensure
|
|
ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
|
|
end
|
|
end
|
|
end
|
|
end
|