Alexey Dubovskoy
85f417f8d2
re: RuboCop - Use nested module/class definition instead of compact style.
2016-06-20 22:15:20 +01:00
Alexey Dubovskoy
024b2d51d3
re: RuboCop - replace rocket style hashes
2016-06-20 22:14:12 +01:00
Alexey Dubovskoy
f15f6850de
re: RuboCop: Bulk minor style corrections
2016-06-20 22:12:16 +01:00
Benjamin Fleischer
32a3b53892
Bump to 0.10.1
2016-06-16 09:41:10 -05:00
Onome
580492282f
Fix #1759 , Grape integration, adds serialization_context ( #4 )
...
* Fix #1759 , Grape integration, adds serialization_context
- `serialization_context` is added in grape formatter so grape continues to render models without an explicit call to the `render` helper method
- Made it straightforward for subclasses to add other serializer options (such as `serialization_scope`).
* Updated Grape tests to include:
- paginated collections
- implicit Grape serializer (i.e. without explicit invocation of `render` helper method)
* Update Changelog with fixes.
2016-06-14 09:46:22 -05:00
Benjamin Fleischer
a7296e8a92
Fix #1759 , Grape integration, adds serialization_context
...
- improves improves serialization_context to take options and not depend
on a `request` object.
- adds descriptive error on missing serialization_context.
- Document overriding `CollectionSerializer#paginated?`.
2016-06-14 09:45:30 -05:00
Filippos Vasilakis
be01fc8ee7
Pass fields down from constructor
2016-06-09 03:26:52 -05:00
Benjamin Fleischer
cd9689683c
Merge branch 'ouvrages-exclude_nil_links'
2016-06-09 02:55:32 -05:00
Benjamin Fleischer
b599360ae3
Provide convenience serializer_class for all the self.class calls
...
per groyoh
https://github.com/rails-api/active_model_serializers/pull/1781#discussion_r66021340
2016-06-07 20:28:50 -05:00
Benjamin Fleischer
5375e009e2
Test caching with fragmented key
...
- on association, fix up assocation logic
- on attribute
2016-06-07 20:26:38 -05:00
Benjamin Fleischer
b8924157d7
Remove remaining fragmented cache class
2016-06-07 03:42:03 -05:00
Benjamin Fleischer
253205bb49
Improve Coverage
2016-06-07 01:50:03 -05:00
Benjamin Fleischer
35a7c81034
Fix up caching, especially fragment_cache
2016-06-07 00:52:05 -05:00
Benjamin Fleischer
7254d34c90
Move Serializer#serialize into Serializer#serializable_hash
2016-06-05 23:33:37 -05:00
Benjamin Fleischer
913f396bb1
Move adapter cache properties to class level (where they belong).
2016-06-04 15:00:51 -05:00
Benjamin Fleischer
516e7da8ff
Move serialization logic into Serializer and CollectionSerializer
2016-06-04 14:59:51 -05:00
Benjamin Fleischer
41575e36f7
Moving Attributes#serializable_hash_for_single_resource to Serializer
2016-06-04 14:59:51 -05:00
Benjamin Fleischer
f28e486d4a
Remove Attributes adapter recursion
2016-06-04 14:59:51 -05:00
Ben Mills
d900b09f8d
Upgrade to rubocop ~> 0.40.0
2016-06-01 09:21:29 -06:00
Benjamin Fleischer
385abb4ba0
Simplify Serializer#cached_attributes to take a fields argument
2016-06-01 01:02:17 -05:00
Benjamin Fleischer
ba23de686d
Complete extracting to Serializer#cached_attributes
2016-06-01 01:02:13 -05:00
Benjamin Fleischer
96750b2f9a
Remove unnecessary Serializer#cached_fields
2016-06-01 00:47:10 -05:00
Benjamin Fleischer
eb86663393
Remove unnecessary Adapter::Base#resource_object_for
2016-06-01 00:43:24 -05:00
Benjamin Fleischer
fcfbc0d529
Merge pull request #1764 from bf4/serializer_cleanup_2
...
Remove unnecessary Adapter::Base#cache_attributes
2016-06-01 00:42:54 -05:00
Benjamin Fleischer
ee518e1856
Remove unnecessary Adapter::Base#cache_attributes
2016-06-01 00:35:11 -05:00
Benjamin Fleischer
0cc87fde40
Remove unnecessary Adapter::Base#cache_check
2016-06-01 00:15:29 -05:00
Benjamin Fleischer
5a4eef6cea
Remove IncludeTree; missing from #1685
2016-05-30 23:08:23 -05:00
Lucas Hosseini
f48fd2a327
Extract IncludeTree. ( #1685 )
2016-05-28 10:07:11 -04:00
L. Preston Sego III
7d7329bbcf
Merge pull request #1426 from brigade/default-include
...
Add a default_include_tree config variable to ActiveModel::Serializer
2016-05-26 13:31:53 -04:00
Ben Mills
9cffc10208
Add Rails >= 5.0.beta3 JSON API params parsing ( #1751 )
...
This reverts commit 6288203277 .
2016-05-26 11:19:23 -06:00
Ben Mills
6288203277
Revert "Add Rails >= 5.0.beta3 JSON API params parsing" ( #1751 )
2016-05-26 11:17:32 -06:00
Noah Silas
94db09b3f6
Fix RuboCop 0.40 linter errors ( #1722 )
...
These errors are breaking the build, which seems to use RuboCop 0.40 [1]
despite the Gemfile.lock pinning rubocop to 0.38.
New lints that I am updating the code style to reflect:
- Style/EmptyCaseCondition: Do not use empty case condition, instead use
an if expression.
- Style/MultilineArrayBraceLayout: Closing array brace must be on the
same line as the last array element when opening brace is on the same
line as the first array element.
- Style/MultilineHashBraceLayout: Closing hash brace must be on the same
line as the last hash element when opening brace is on the same line
as the first hash element.
- Style/MultilineMethodCallBraceLayout: Closing method call brace must
be on the line after the last argument when opening brace is on a
separate line from the first argument.
[1] https://github.com/bbatsov/rubocop/releases/tag/v0.40.0
2016-05-26 12:58:05 -04:00
Benjamin Fleischer
8a3196d920
Improve jsonapi mime type registration for Rails 5 ( #1747 )
2016-05-26 10:55:12 -06:00
Ben Woosley
8c18d18cdb
Add default_includes configuration
...
This is useful to set application-wide default behavior - e.g. in
previous versions of AMS the default behavior was to serialize the
full object graph by default - equivalent to the '**' include tree.
Currently just the global setting, but I think this could also work
on a per-serializer basis, with more attention.
2016-05-26 00:16:14 +00:00
Yohan Robert
a701777bd5
Prevent loading association when include_data is set to false ( #1710 )
...
This should fix #1707 .
2016-05-24 20:46:22 -04:00
Ben Mills
b6d4ec03de
Bump to v0.10.0
2016-05-17 12:49:37 -06:00
cgmckeever
bbed12864d
adds polymorphic option to association definition which includes association type in serializer
...
regen gemlock
regen gemlock
better variable naming
rubocop fixes
adds to changelog
adds empty relationship and has_many polymorph tests
indent
test cleaning
-rubocop
rubocop
rubocop
rubocop
changelog
remove silly .DS
fix roque failure
fix
2016-05-17 12:30:59 -05:00
Benjamin Fleischer
6c321cd862
Assert Schema ( #1677 )
...
* Assert Schema
* Fix regression from #1695 where JSONAPI renders empty meta
* Add changelog
2016-05-17 13:22:38 -04:00
Benjamin Fleischer
9f59398f2b
Merge pull request #1732 from remear/jsonapi-renderer
...
Include ControllerSupport on ActiveSupport on_load action_controller
2016-05-17 12:10:17 -05:00
Ben Mills
7356071ea0
Include ControllerSupport on ActiveSupport on_load action_controller
2016-05-17 09:39:30 -06:00
Benjamin Fleischer
93cad825b7
Include actual exception message with custom exceptions
2016-05-17 10:32:53 -05:00
Benjamin Fleischer
d0d7af470c
Test::Schema exceptions should be Minitest::Assertions
2016-05-17 10:31:35 -05:00
Benjamin Fleischer
05fd59644d
Setting the content_type sets the response Content-Type
...
Otherwise we have two headers, 'Content-Type' and 'CONTENT_TYPE'.
I don't know when Rails decides to use one or the other.
2016-05-01 23:30:52 -05:00
Fumiaki MATSUSHIMA
aa087a22b5
String/Lambda support for conditional attributes/associations
2016-04-26 21:37:25 +09:00
Nader Akhnoukh
37ca0c1f6c
Support pagination link for Kaminari when no data is returned
2016-04-22 11:04:40 -06:00
Lucas Hosseini
e804d37924
Meta no longer handled in Base adapter.
2016-04-21 18:25:17 +02:00
Benjamin Fleischer
7485c8487e
Merge pull request #1687 from bf4/lazyify_calculating_caller_digest
...
Lazify calculating caller file digest until used
2016-04-18 16:09:24 -05:00
Benjamin Fleischer
1d24c9708a
Lazify calculating caller file digest until used
2016-04-18 12:04:31 -05:00
Benjamin Fleischer
b7e2bc06ed
Memoize resource relationships
...
bin/bench_regression
"version": "0.10.0.rc5",
"rails_version": "4.2.6",
"benchmark_run[environment]": "2.2.2p95",
perf/only_calc_associations_once
"commit_hash": "1e7c428",
caching on: caching serializers: gc off 741.7702402782281/ips; 1355 objects
caching on: non-caching serializers: gc off 712.3752615532874/ips; 1257 objects
caching off: caching serializers: gc off 706.0789199312495/ips; 1355 objects
caching off: non-caching serializers: gc off 751.5310710635379/ips; 1257 objects
master
"commit_hash": "1033b711c7d7c231bb5b832e7dfe7f99389f22c4"
caching on: caching serializers: gc off 567.7959835633892/ips; 1803 objects
caching on: non-caching serializers: gc off 776.4929551133658/ips; 1257 objects
caching off: caching serializers: gc off 538.046851190591/ips; 1803 objects
caching off: non-caching serializers: gc off 738.5596630209004/ips; 1257 objects
2016-04-18 11:11:13 -05:00
Benjamin Fleischer
cc80eba9c9
Refactor fragment cache logic some more
2016-04-13 01:08:10 -05:00