11 Commits

Author	SHA1	Message	Date
Jo Liss	ee3cec3d0c	When objects are sideloaded multiple times, serialize them only once ... To achieve this, we make the following change when sideloading: Instead of serializing associations and discarding duplicate *hashes*, we memorize the *objects* (records) that we have already serialized, and only serialize those that are new. This change is mostly transparent, and brings down serialization time from 3.1 seconds to 1.0 seconds on my set of sample data. There is one change in the behavior: If you sideload the same object multiple times, and it yields different hashes, like so: embed :ids, include: true has_many :comments has_many :recent_comments, root: comments, serializer: CommentShortSerializer then previously, it would be included multiple times, whereas now, the first hash wins. (I haven't actually tested this.) I don't know that either option is preferable. It's not covered by the test suite, and I think it's an edge case that is OK to ignore entirely.	2012-10-29 23:15:32 +01:00
Jo Liss	28ee88ca9a	In the test, use the same :hash across serializers ... Otherwise, `include!` will not remember the unique_values of already-sideloaded hashes across serializer calls.	2012-10-29 22:48:51 +01:00
Tee Parham	9962069ae9	delete identical test	2012-05-30 10:55:35 -06:00
Yehuda Katz	671fc14888	remove scope as a separate concept and pass it in ... as an option.	2012-01-11 21:16:02 -07:00
Yehuda Katz	4ad9c64e46	Allow serializers to receive instructions to ... explicitly include or exclude specific lists of associations.	2012-01-11 20:56:36 -07:00
Yehuda Katz	cb316b00f7	Write more tests	2012-01-11 20:28:07 -07:00
Yehuda Katz	2bae9363c7	Test custom embed options per association	2012-01-11 20:21:29 -07:00
Yehuda Katz	89103f1e74	Test that has_one works.	2012-01-11 13:07:43 -07:00
Yehuda Katz	72b8213bee	If an existing association exists, use it to ... get the value if none was provided.	2012-01-11 13:06:19 -07:00
Yehuda Katz	dd0b56c748	HasOne associations work	2012-01-11 12:26:49 -07:00
Yehuda Katz	f9d0259340	Start cleaning up serializers to support ... include/exclude functionality. This process involves building a few lower-level primitives so not as much logic is hardcoded in monolithic helper methods.	2012-01-11 12:18:18 -07:00