Clean up interface inconistency

This commit is contained in:
twinturbo 2012-07-14 14:19:08 +02:00
parent 535a33a33b
commit e3888f0a40
2 changed files with 7 additions and 7 deletions

View File

@ -74,7 +74,7 @@ module ActiveModel
class << self
# set peform caching like root
def cache(value = true)
def cached(value = true)
self.perform_caching = value
end
@ -441,7 +441,7 @@ module ActiveModel
end
def perform_caching?
perform_caching && cache && try(:cache_key)
perform_caching && cache && respond_to?(:cache_key)
end
def expand_cache_key(*args)

View File

@ -38,12 +38,12 @@ class CachingTest < ActiveModel::TestCase
def test_serializers_have_a_cache_store
ActiveModel::Serializer.cache = NullStore.new
assert ActiveModel::Serializer.cache
assert_kind_of NullStore, ActiveModel::Serializer.cache
end
def test_serializers_can_enable_caching
serializer = Class.new(ActiveModel::Serializer) do
cache true
cached true
end
assert serializer.perform_caching
@ -51,7 +51,7 @@ class CachingTest < ActiveModel::TestCase
def test_serializers_cache_serializable_hash
serializer = Class.new(ActiveModel::Serializer) do
cache true
cached true
attributes :name, :skills
def self.to_s
@ -76,7 +76,7 @@ class CachingTest < ActiveModel::TestCase
def test_serializers_cache_to_json
serializer = Class.new(ActiveModel::Serializer) do
cache true
cached true
attributes :name, :skills
def self.to_s
@ -101,7 +101,7 @@ class CachingTest < ActiveModel::TestCase
def test_can_use_defined_cache_key
serializer = Class.new(ActiveModel::Serializer) do
cache true
cached true
attributes :name, :skills
def self.to_s