ditkrg/active_model_serializers
4
0
Fork 0
mirror of https://github.com/ditkrg/active_model_serializers.git synced 2026-01-24 23:06:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Encapsulate serialized_associations; test inline associations

Browse Source
This commit is contained in:
Benjamin Fleischer 2015-11-30 17:47:12 -06:00
parent 7cbef1b3b5
commit e2903643c5
2 changed files with 42 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/active_model/serializer/associations.rb
View File

@ -13,7 +13,9 @@ module ActiveModel
DEFAULT_INCLUDE_TREE = ActiveModel::Serializer::IncludeTree.from_string('*') DEFAULT_INCLUDE_TREE = ActiveModel::Serializer::IncludeTree.from_string('*')
included do |base| included do |base|
base.class_attribute :_reflections base.class_attribute :serialized_associations, instance_writer: false # @api public: maps association name to 'Reflection' instance
base.serialized_associations ||= {}
base.class_attribute :_reflections, instance_writer: false
base._reflections ||= [] base._reflections ||= []
extend ActiveSupport::Autoload extend ActiveSupport::Autoload
@ -77,13 +79,16 @@ module ActiveModel
def associate(reflection, block) def associate(reflection, block)
self._reflections = _reflections.dup self._reflections = _reflections.dup
define_method reflection.name do reflection_name = reflection.name
if block_given? if block
instance_eval(&block) serialized_associations[reflection_name] = ->(instance) { instance.instance_eval(&block) }
else else
object.send reflection.name serialized_associations[reflection_name] = ->(instance) { instance.object.send(reflection_name) }
end end
end unless method_defined?(reflection.name)
define_method reflection_name do
serialized_associations[reflection_name].call(self)
end unless method_defined?(reflection_name)
self._reflections << reflection self._reflections << reflection
end end

29
test/serializers/associations_test.rb
View File

@ -126,6 +126,35 @@ module ActiveModel
assert expected_association_keys.include? :site assert expected_association_keys.include? :site
end end
class InlineAssociationTestPostSerializer < ActiveModel::Serializer
has_many :comments
has_many :last_comments do
object.comments.last(1)
end
end
def test_virtual_attribute_block
comment1 = ::ARModels::Comment.create!(contents: 'first comment')
comment2 = ::ARModels::Comment.create!(contents: 'last comment')
post = ::ARModels::Post.create!(
title: 'inline association test',
body: 'etc',
comments: [comment1, comment2]
)
actual = serializable(post, adapter: :attributes, serializer: InlineAssociationTestPostSerializer).as_json
expected = {
:comments => [
{ :id => 1, :contents => 'first comment' },
{ :id => 2, :contents => 'last comment' }
],
:last_comments => [
{ :id => 2, :contents => 'last comment' }
]
}
assert_equal expected, actual
end
class NamespacedResourcesTest < Minitest::Test class NamespacedResourcesTest < Minitest::Test
class ResourceNamespace class ResourceNamespace
Post = Class.new(::Model) Post = Class.new(::Model)