ditkrg/active_model_serializers
4
0
Fork 0
mirror of https://github.com/ditkrg/active_model_serializers.git synced 2026-01-24 14:56:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused controller rescue_with_handler

Browse Source 
Per
https://github.com/rails-api/active_model_serializers/pull/954#discussion_r32589882

Ref 917, 918
This commit is contained in:
Benjamin Fleischer 2015-06-20 23:45:29 -05:00
parent a66df3009a
commit df140293d3
2 changed files with 0 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/action_controller/serialization.rb
View File

@ -52,25 +52,6 @@ module ActionController
end end
end end
# Tries to rescue the exception by looking up and calling a registered handler.
#
# Possibly Deprecated
# TODO: Either Decorate 'exception' and define #handle_error where it is serialized
# For example:
# class ExceptionModel
# include ActiveModel::Serialization
# def initialize(exception)
# # etc
# end
# def handle_error(exception)
# exception_model = ActiveModel::Serializer.build_exception_model({ errors: ['Internal Server Error'] })
# render json: exception_model, status: :internal_server_error
# end
# OR remove method as it doesn't do anything right now.
def rescue_with_handler(exception)
super(exception)
end
module ClassMethods module ClassMethods
def serialization_scope(scope) def serialization_scope(scope)
self._serialization_scope = scope self._serialization_scope = scope

32
test/action_controller/rescue_from_test.rb
View File

@ -1,32 +0,0 @@
require 'test_helper'
module ActionController
module Serialization
class RescueFromTest < ActionController::TestCase
class RescueFromTestController < ActionController::Base
rescue_from Exception, with: :handle_error
def render_using_raise_error_serializer
profile = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
render json: [profile], serializer: RaiseErrorSerializer
end
def handle_error(exception)
render json: { errors: ['Internal Server Error'] }, status: :internal_server_error
end
end
tests RescueFromTestController
def test_rescue_from
get :render_using_raise_error_serializer
expected = {
errors: ['Internal Server Error']
}.to_json
assert_equal expected, response.body
end
end
end
end