From caf4910b6e4e3af1bd5cac1116bc9aedd8cd2b1f Mon Sep 17 00:00:00 2001 From: Benjamin Fleischer Date: Sat, 4 Jun 2016 14:47:22 -0500 Subject: [PATCH] Remove controller :assigns warnings/shim --- test/action_controller/adapter_selector_test.rb | 2 +- test/action_controller/explicit_serializer_test.rb | 4 ++-- test/action_controller/serialization_test.rb | 6 +++--- test/support/rails_app.rb | 9 --------- 4 files changed, 6 insertions(+), 15 deletions(-) diff --git a/test/action_controller/adapter_selector_test.rb b/test/action_controller/adapter_selector_test.rb index aa3539f7..f392b4a4 100644 --- a/test/action_controller/adapter_selector_test.rb +++ b/test/action_controller/adapter_selector_test.rb @@ -32,7 +32,7 @@ module ActionController expected = { data: { - id: assigns(:profile).id.to_s, + id: @controller.instance_variable_get(:@profile).id.to_s, type: 'profiles', attributes: { name: 'Name 1', diff --git a/test/action_controller/explicit_serializer_test.rb b/test/action_controller/explicit_serializer_test.rb index 00b4db81..8886d07d 100644 --- a/test/action_controller/explicit_serializer_test.rb +++ b/test/action_controller/explicit_serializer_test.rb @@ -103,9 +103,9 @@ module ActionController { 'title' => 'New Post', 'body' => 'Body', - 'id' => assigns(:post).id, + 'id' => @controller.instance_variable_get(:@post).id, 'comments' => [{ 'id' => 1 }, { 'id' => 2 }], - 'author' => { 'id' => assigns(:author).id } + 'author' => { 'id' => @controller.instance_variable_get(:@author).id } } ] diff --git a/test/action_controller/serialization_test.rb b/test/action_controller/serialization_test.rb index 196d8493..8ffdc100 100644 --- a/test/action_controller/serialization_test.rb +++ b/test/action_controller/serialization_test.rb @@ -163,7 +163,7 @@ module ActionController end expected = { data: { - id: assigns(:profile).id.to_s, + id: @controller.instance_variable_get(:@profile).id.to_s, type: 'profiles', attributes: { name: 'Name 1', @@ -246,7 +246,7 @@ module ActionController expected = { data: [ { - id: assigns(:profiles).first.id.to_s, + id: @controller.instance_variable_get(:@profiles).first.id.to_s, type: 'profiles', attributes: { name: 'Name 1', @@ -269,7 +269,7 @@ module ActionController expected = { data: [ { - id: assigns(:profiles).first.id.to_s, + id: @controller.instance_variable_get(:@profiles).first.id.to_s, type: 'profiles', attributes: { name: 'Name 1', diff --git a/test/support/rails_app.rb b/test/support/rails_app.rb index 16e776c7..0bbae1fe 100644 --- a/test/support/rails_app.rb +++ b/test/support/rails_app.rb @@ -22,15 +22,6 @@ ActionController::TestCase.class_eval do def setup @routes = Routes end - - # For Rails5 - # https://github.com/rails/rails/commit/ca83436d1b3b6cedd1eca2259f65661e69b01909#diff-b9bbf56e85d3fe1999f16317f2751e76L17 - def assigns(key = nil) - warn "DEPRECATION: Calling 'assigns(#{key})' from #{caller[0]}" - assigns = {}.with_indifferent_access - @controller.view_assigns.each { |k, v| assigns.regular_writer(k, v) } - key.nil? ? assigns : assigns[key] - end end # ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate", __FILE__)]