Adds support for meta attribute

Currently, 0.10.0.pre doesn't support `meta` option in `render`. This
way, there's no way to support features such as pagination. `0.9` had
this feature in place.

This adds support for it, as well as fixes small things in README.md.

This won't support `meta` in array responses because arrays don't have
keys, obviously. Also, the response should have a `root` key, otherwise
no `meta` will be included.

In some cases, for example using JsonApi, ArraySerializer will result in
a response with a `root`. In that case, `meta` will be included.
This commit is contained in:
Alexandre de Oliveira 2015-01-05 01:00:03 -02:00
parent 282de21984
commit bd27da1b76
7 changed files with 170 additions and 15 deletions

3
CHANGELOG.md Normal file
View File

@ -0,0 +1,3 @@
### 0.10.0
* adds support for `meta` and `meta_key` [@kurko]

View File

@ -54,18 +54,17 @@ end
``` ```
Generally speaking, you as a user of AMS will write (or generate) these Generally speaking, you as a user of AMS will write (or generate) these
serializer classes. By default, they will use the JsonApiAdapter, implemented serializer classes. If you want to use a different adapter, such as a JsonApi, you can
by AMS. If you want to use a different adapter, such as a HalAdapter, you can
change this in an initializer: change this in an initializer:
```ruby ```ruby
ActiveModel::Serializer.config.adapter = ActiveModel::Serializer::Adapter::HalAdapter ActiveModel::Serializer.config.adapter = ActiveModel::Serializer::Adapter::JsonApi
``` ```
or or
```ruby ```ruby
ActiveModel::Serializer.config.adapter = :hal ActiveModel::Serializer.config.adapter = :json_api
``` ```
You won't need to implement an adapter unless you wish to use a new format or You won't need to implement an adapter unless you wish to use a new format or
@ -99,15 +98,6 @@ end
In this case, Rails will look for a serializer named `PostSerializer`, and if In this case, Rails will look for a serializer named `PostSerializer`, and if
it exists, use it to serialize the `Post`. it exists, use it to serialize the `Post`.
### Built in Adapters
The `:json_api` adapter will include the associated resources in the `"linked"`
member when the resource names are included in the `include` option.
```ruby
render @posts, include: 'authors,comments'
```
### Specify a serializer ### Specify a serializer
If you wish to use a serializer other than the default, you can explicitly pass it to the renderer. If you wish to use a serializer other than the default, you can explicitly pass it to the renderer.
@ -129,6 +119,46 @@ render json: @posts, each_serializer: PostPreviewSerializer
render json: @posts, serializer: PaginatedSerializer, each_serializer: PostPreviewSerializer render json: @posts, serializer: PaginatedSerializer, each_serializer: PostPreviewSerializer
``` ```
### Meta
If you want a `meta` attribute in your response, specify it in the `render`
call:
```ruby
render json: @post, meta: { total: 10 }
```
The key can be customized using `meta_key` option.
```ruby
render json: @post, meta: { total: 10 }, meta_key: "custom_meta"
```
`meta` will only be included in your response if there's a root. For instance,
it won't be included in array responses.
### Root key
If you want to define a custom root for your response, specify it in the `render`
call:
```ruby
render json: @post, root: "articles"
```
### Built in Adapters
#### JSONAPI
This adapter follows the format specified in
[jsonapi.org/format](http://jsonapi.org/format). It will include the associated
resources in the `"linked"` member when the resource names are included in the
`include` option.
```ruby
render @posts, include: 'authors,comments'
```
## Installation ## Installation
Add this line to your application's Gemfile: Add this line to your application's Gemfile:

View File

@ -114,11 +114,13 @@ module ActiveModel
name.demodulize.underscore.sub(/_serializer$/, '') if name name.demodulize.underscore.sub(/_serializer$/, '') if name
end end
attr_accessor :object, :root attr_accessor :object, :root, :meta, :meta_key
def initialize(object, options = {}) def initialize(object, options = {})
@object = object @object = object
@root = options[:root] || (self.class._root ? self.class.root_name : false) @root = options[:root] || (self.class._root ? self.class.root_name : false)
@meta = options[:meta]
@meta_key = options[:meta_key]
end end
def json_key def json_key

View File

@ -18,7 +18,8 @@ module ActiveModel
end end
def as_json(options = {}) def as_json(options = {})
serializable_hash(options) hash = serializable_hash(options)
include_meta(hash)
end end
def self.create(resource, options = {}) def self.create(resource, options = {})
@ -30,6 +31,25 @@ module ActiveModel
def self.adapter_class(adapter) def self.adapter_class(adapter)
"ActiveModel::Serializer::Adapter::#{adapter.to_s.classify}".safe_constantize "ActiveModel::Serializer::Adapter::#{adapter.to_s.classify}".safe_constantize
end end
private
def meta
serializer.meta if serializer.respond_to?(:meta)
end
def meta_key
serializer.meta_key || "meta"
end
def root
serializer.json_key
end
def include_meta(json)
json[meta_key] = meta if meta && root
json
end
end end
end end
end end

View File

@ -4,6 +4,8 @@ module ActiveModel
include Enumerable include Enumerable
delegate :each, to: :@objects delegate :each, to: :@objects
attr_reader :meta, :meta_key
def initialize(objects, options = {}) def initialize(objects, options = {})
@objects = objects.map do |object| @objects = objects.map do |object|
serializer_class = options.fetch( serializer_class = options.fetch(
@ -12,6 +14,8 @@ module ActiveModel
) )
serializer_class.new(object) serializer_class.new(object)
end end
@meta = options[:meta]
@meta_key = options[:meta_key]
end end
def json_key def json_key

View File

@ -37,6 +37,18 @@ module ActionController
] ]
render json: array render json: array
end end
def render_array_using_implicit_serializer_and_meta
old_adapter = ActiveModel::Serializer.config.adapter
ActiveModel::Serializer.config.adapter = ActiveModel::Serializer::Adapter::JsonApi
array = [
Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
]
render json: array, meta: { total: 10 }
ensure
ActiveModel::Serializer.config.adapter = old_adapter
end
end end
tests MyController tests MyController
@ -87,6 +99,13 @@ module ActionController
assert_equal expected.to_json, @response.body assert_equal expected.to_json, @response.body
end end
def test_render_array_using_implicit_serializer_and_meta
get :render_array_using_implicit_serializer_and_meta
assert_equal 'application/json', @response.content_type
assert_equal '{"profiles":[{"name":"Name 1","description":"Description 1"}],"meta":{"total":10}}', @response.body
end
end end
end end
end end

View File

@ -0,0 +1,77 @@
require 'test_helper'
module ActiveModel
class Serializer
class MetaTest < Minitest::Test
def setup
@blog = Blog.new(id: 1,
name: 'AMS Hints',
writer: Author.new(id: 2, name: "Steve"),
articles: [Post.new(id: 3, title: "AMS")])
end
def test_meta_is_present_with_root
adapter = load_adapter(root: "blog", meta: {total: 10})
expected = {
"blog" => {
id: 1,
title: "AMS Hints"
},
"meta" => {
total: 10
}
}
assert_equal expected, adapter.as_json
end
def test_meta_is_not_included_when_root_is_missing
adapter = load_adapter(meta: {total: 10})
expected = {
id: 1,
title: "AMS Hints"
}
assert_equal expected, adapter.as_json
end
def test_meta_key_is_used
adapter = load_adapter(root: "blog", meta: {total: 10}, meta_key: "haha_meta")
expected = {
"blog" => {
id: 1,
title: "AMS Hints"
},
"haha_meta" => {
total: 10
}
}
assert_equal expected, adapter.as_json
end
def test_meta_is_not_used_on_arrays
serializer = ArraySerializer.new([@blog], root: "blog", meta: {total: 10}, meta_key: "haha_meta")
adapter = ActiveModel::Serializer::Adapter::Json.new(serializer)
expected = [{
id: 1,
name: "AMS Hints",
writer: {
id: 2,
name: "Steve"
},
articles: [{
id: 3,
title: "AMS",
body: nil
}]
}]
assert_equal expected, adapter.as_json
end
private
def load_adapter(options)
serializer = AlternateBlogSerializer.new(@blog, options)
ActiveModel::Serializer::Adapter::Json.new(serializer)
end
end
end
end