re: RuboCop - Use nested module/class definition instead of compact style.

.rubocop.yml

@@ -46,7 +46,7 @@ Style/AlignParameters:
   EnforcedStyle: with_fixed_indentation
 
 Style/ClassAndModuleChildren:
-  EnforcedStyle: compact
+  EnforcedStyle: nested
 
 Style/Documentation:
   Enabled: false

.rubocop_todo.yml

@@ -12,13 +12,6 @@ Lint/HandleExceptions:
     - 'Rakefile'
 
 
-# Offense count: 271
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-
 
 # Offense count: 3
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.

lib/active_model/serializer/array_serializer.rb

@@ -1,9 +1,12 @@
 require 'active_model/serializer/collection_serializer'
-class ActiveModel::Serializer
+
+module ActiveModel
+  class Serializer
     class ArraySerializer < CollectionSerializer
       class << self
         extend ActiveModelSerializers::Deprecate
         deprecate :new, 'ActiveModel::Serializer::CollectionSerializer.'
       end
     end
+  end
 end

lib/active_model/serializer/error_serializer.rb

@@ -1,4 +1,6 @@
-class ActiveModel::Serializer::ErrorSerializer < ActiveModel::Serializer
+module ActiveModel
+  class Serializer
+    class ErrorSerializer < ActiveModel::Serializer
       # @return [Hash<field_name,Array<error_message>>]
       def as_json
         object.errors.messages
@@ -7,4 +9,6 @@ class ActiveModel::Serializer::ErrorSerializer < ActiveModel::Serializer
       def success?
         false
       end
+    end
+  end
 end

lib/active_model/serializer/errors_serializer.rb

@@ -1,5 +1,8 @@
 require 'active_model/serializer/error_serializer'
-class ActiveModel::Serializer::ErrorsSerializer
+
+module ActiveModel
+  class Serializer
+    class ErrorsSerializer
       include Enumerable
       delegate :each, to: :@serializers
       attr_reader :object, :root
@@ -24,4 +27,6 @@ class ActiveModel::Serializer::ErrorsSerializer
       protected
 
       attr_reader :serializers
+    end
+  end
 end

lib/active_model/serializer/lint.rb

@@ -1,4 +1,6 @@
-module ActiveModel::Serializer::Lint
+module ActiveModel
+  class Serializer
+    module Lint
       # == Active \Model \Serializer \Lint \Tests
       #
       # You can test whether an object is compliant with the Active \Model \Serializers
@@ -143,4 +145,6 @@ module ActiveModel::Serializer::Lint
           assert result.instance_of?(name), "#{result} should be an instance of #{name}"
         end
       end
+    end
+  end
 end

lib/active_model_serializers/register_jsonapi_renderer.rb

@@ -22,7 +22,8 @@
 # render jsonapi: model
 #
 # No wrapper format needed as it does not apply (i.e. no `wrap_parameters format: [jsonapi]`)
-module ActiveModelSerializers::Jsonapi
+module ActiveModelSerializers
+  module Jsonapi
     MEDIA_TYPE = 'application/vnd.api+json'.freeze
     HEADERS = {
       response: { 'CONTENT_TYPE'.freeze => MEDIA_TYPE },
@@ -67,6 +68,7 @@ module ActiveModelSerializers::Jsonapi
         get_serializer(json, options)
       end
     end
+  end
 end
 
 ActiveModelSerializers::Jsonapi.install

lib/grape/active_model_serializers.rb

@@ -4,11 +4,13 @@ require 'active_model_serializers'
 require 'grape/formatters/active_model_serializers'
 require 'grape/helpers/active_model_serializers'
 
-module Grape::ActiveModelSerializers
+module Grape
+  module ActiveModelSerializers
     extend ActiveSupport::Concern
 
     included do
       formatter :json, Grape::Formatters::ActiveModelSerializers
       helpers Grape::Helpers::ActiveModelSerializers
     end
+  end
 end

test/active_model_serializers/json_pointer_test.rb

@@ -1,6 +1,7 @@
 require 'test_helper'
 
-class ActiveModelSerializers::JsonPointerTest < ActiveSupport::TestCase
+module ActiveModelSerializers
+  class JsonPointerTest < ActiveSupport::TestCase
     def test_attribute_pointer
       attribute_name = 'title'
       pointer = ActiveModelSerializers::JsonPointer.new(:attribute, attribute_name)
@@ -17,4 +18,5 @@ class ActiveModelSerializers::JsonPointerTest < ActiveSupport::TestCase
         ActiveModelSerializers::JsonPointer.new(:unknown)
       end
     end
+  end
 end

test/active_model_serializers/key_transform_test.rb

@@ -1,6 +1,7 @@
 require 'test_helper'
 
-class ActiveModelSerializers::KeyTransformTest < ActiveSupport::TestCase
+module ActiveModelSerializers
+  class KeyTransformTest < ActiveSupport::TestCase
     def test_camel
       obj = Object.new
       scenarios = [
@@ -260,4 +261,5 @@ class ActiveModelSerializers::KeyTransformTest < ActiveSupport::TestCase
         assert_equal s[:expected], result
       end
     end
+  end
 end

test/active_model_serializers/model_test.rb

@@ -1,9 +1,11 @@
 require 'test_helper'
 
-class ActiveModelSerializers::ModelTest < ActiveSupport::TestCase
+module ActiveModelSerializers
+  class ModelTest < ActiveSupport::TestCase
     include ActiveModel::Serializer::Lint::Tests
 
     def setup
       @resource = ActiveModelSerializers::Model.new
     end
+  end
 end

test/grape_test.rb

@@ -5,7 +5,8 @@ require 'kaminari'
 require 'kaminari/hooks'
 ::Kaminari::Hooks.init
 
-class ActiveModelSerializers::GrapeTest < ActiveSupport::TestCase
+module ActiveModelSerializers
+  class GrapeTest < ActiveSupport::TestCase
     include Rack::Test::Methods
     module Models
       def self.model1
@@ -173,4 +174,5 @@ class ActiveModelSerializers::GrapeTest < ActiveSupport::TestCase
       assert representation.include?('links')
       assert representation['links'].count > 0
     end
+  end
 end

test/logger_test.rb

@@ -1,6 +1,7 @@
 require 'test_helper'
 
-class ActiveModelSerializers::LoggerTest < ActiveSupport::TestCase
+module ActiveModelSerializers
+  class LoggerTest < ActiveSupport::TestCase
     def test_logger_is_set_to_action_controller_logger_when_initializer_runs
       assert_equal $action_controller_logger, ActionController::Base.logger # rubocop:disable Style/GlobalVars
     end
@@ -15,4 +16,5 @@ class ActiveModelSerializers::LoggerTest < ActiveSupport::TestCase
     ensure
       ActiveModelSerializers.logger = original_logger
     end
+  end
 end

test/support/isolated_unit.rb

@@ -75,6 +75,8 @@ module TestHelpers
   end
 end
 
-class ActiveSupport::TestCase
+module ActiveSupport
+  class TestCase
     include TestHelpers::Generation
+  end
 end

test/support/serialization_testing.rb

@@ -44,10 +44,12 @@ module SerializationTesting
   end
 end
 
-class Minitest::Test
+module Minitest
+  class Test
     def before_setup
       ActionController::Base.cache_store.clear
     end
 
     include SerializationTesting
+  end
 end