From 63317699f3d151813cf304d6aa1685f50e2bb085 Mon Sep 17 00:00:00 2001 From: Lucas Hosseini Date: Sat, 10 Oct 2015 15:40:38 +0200 Subject: [PATCH] Correct minor typos --- lib/active_model/serializer.rb | 10 +++++----- .../serializer/adapter/fragment_cache.rb | 18 +++++++++--------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/active_model/serializer.rb b/lib/active_model/serializer.rb index 318e986e..6b974917 100644 --- a/lib/active_model/serializer.rb +++ b/lib/active_model/serializer.rb @@ -116,7 +116,7 @@ module ActiveModel # @api private # Used by FragmentCache on the CachedSerializer - # to call attribute methods on the fragmented cached serializer + # to call attribute methods on the fragmented cached serializer. def self.fragmented(serializer) self._fragmented = serializer end @@ -174,7 +174,7 @@ module ActiveModel end # Used to cache serializer name => serializer class - # when looked up by Serializer.get_serializer_for + # when looked up by Serializer.get_serializer_for. def self.serializers_cache @serializers_cache ||= ThreadSafe::Cache.new end @@ -215,8 +215,8 @@ module ActiveModel attr_accessor :object, :root, :scope # `scope_name` is set as :current_user by default in the controller. - # If the instance does not have a method nameed `scope_name`, it - # defines the method so that calls the +scope+. + # If the instance does not have a method named `scope_name`, it + # defines the method so that it calls the +scope+. def initialize(object, options = {}) self.object = object self.instance_options = options @@ -231,7 +231,7 @@ module ActiveModel end end - # Used by adapter as resource root + # Used by adapter as resource root. def json_key root || object.class.model_name.to_s.underscore end diff --git a/lib/active_model/serializer/adapter/fragment_cache.rb b/lib/active_model/serializer/adapter/fragment_cache.rb index c6c0aaec..5c97a64a 100644 --- a/lib/active_model/serializer/adapter/fragment_cache.rb +++ b/lib/active_model/serializer/adapter/fragment_cache.rb @@ -12,12 +12,12 @@ module ActiveModel # TODO: Use Serializable::Resource # TODO: call +constantize+ less - # 1. Create a CachedSerializer and NonCachedSerializer from the serializer class. - # 2. Serialize the above two with the given adapter. - # 3. Pass their serializations to the adapter +::fragment_cache+. + # 1. Create a CachedSerializer and NonCachedSerializer from the serializer class + # 2. Serialize the above two with the given adapter + # 3. Pass their serializations to the adapter +::fragment_cache+ def fetch klass = serializer.class - # It will split the serializer into two, one that will be cached and other wont + # It will split the serializer into two, one that will be cached and one that will not serializers = fragment_serializer(serializer.object.class.name, klass) # Instantiate both serializers @@ -41,9 +41,9 @@ module ActiveModel private - # Given a serializer class and a hash of its cached and non0cached serializers - # 1. Determine cached attributes from serializer class options. - # 2. Add cached attributes to cached Serializer. + # Given a serializer class and a hash of its cached and non-cached serializers + # 1. Determine cached attributes from serializer class options + # 2. Add cached attributes to cached Serializer # 3. Add non-cached attributes to non-cached Serializer def cached_attributes(klass, serializers) attributes = serializer.class._attributes @@ -66,8 +66,8 @@ module ActiveModel end # Given a resource name and its serializer's class - # 1. Dyanmically creates a CachedSerializer and NonCachedSerializer - # for a given class 'name'. + # 1. Dyanmically creates a CachedSerializer and NonCachedSerializer + # for a given class 'name' # 2. Call # CachedSerializer.cache(serializer._cache_options) # CachedSerializer.fragmented(serializer)