mirror of
https://github.com/ditkrg/active_model_serializers.git
synced 2026-01-25 15:23:06 +00:00
Refactor adapters to implement support for array serialization
This commit is contained in:
@@ -23,6 +23,14 @@ module ActionController
|
||||
ensure
|
||||
ActiveModel::Serializer.config.adapter = old_adapter
|
||||
end
|
||||
|
||||
def render_array_using_implicit_serializer
|
||||
array = [
|
||||
Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' }),
|
||||
Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })
|
||||
]
|
||||
render json: array
|
||||
end
|
||||
end
|
||||
|
||||
tests MyController
|
||||
@@ -46,7 +54,25 @@ module ActionController
|
||||
get :render_using_default_adapter_root
|
||||
|
||||
assert_equal 'application/json', @response.content_type
|
||||
assert_equal '{"profile":{"name":"Name 1","description":"Description 1"}}', @response.body
|
||||
assert_equal '{"profiles":{"name":"Name 1","description":"Description 1"}}', @response.body
|
||||
end
|
||||
|
||||
def test_render_array_using_implicit_serializer
|
||||
get :render_array_using_implicit_serializer
|
||||
assert_equal 'application/json', @response.content_type
|
||||
|
||||
expected = [
|
||||
{
|
||||
name: 'Name 1',
|
||||
description: 'Description 1',
|
||||
},
|
||||
{
|
||||
name: 'Name 2',
|
||||
description: 'Description 2',
|
||||
}
|
||||
]
|
||||
|
||||
assert_equal expected.to_json, @response.body
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
28
test/adapter/json/collection_test.rb
Normal file
28
test/adapter/json/collection_test.rb
Normal file
@@ -0,0 +1,28 @@
|
||||
require 'test_helper'
|
||||
|
||||
module ActiveModel
|
||||
class Serializer
|
||||
class Adapter
|
||||
class Json
|
||||
class Collection < Minitest::Test
|
||||
def setup
|
||||
@first_post = Post.new(id: 1, title: 'Hello!!', body: 'Hello, world!!')
|
||||
@second_post = Post.new(id: 2, title: 'New Post', body: 'Body')
|
||||
@first_post.comments = []
|
||||
@second_post.comments = []
|
||||
|
||||
@serializer = ArraySerializer.new([@first_post, @second_post])
|
||||
@adapter = ActiveModel::Serializer::Adapter::Json.new(@serializer)
|
||||
end
|
||||
|
||||
def test_include_multiple_posts
|
||||
assert_equal([
|
||||
{title: "Hello!!", body: "Hello, world!!", id: 1, comments: []},
|
||||
{title: "New Post", body: "Body", id: 2, comments: []}
|
||||
], @adapter.serializable_hash)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -16,7 +16,7 @@ module ActiveModel
|
||||
end
|
||||
|
||||
def test_includes_post_id
|
||||
assert_equal(42, @adapter.serializable_hash[:links][:post])
|
||||
assert_equal(42, @adapter.serializable_hash[:comments][:links][:post])
|
||||
end
|
||||
|
||||
def test_includes_linked_post
|
||||
|
||||
28
test/adapter/json_api/collection_test.rb
Normal file
28
test/adapter/json_api/collection_test.rb
Normal file
@@ -0,0 +1,28 @@
|
||||
require 'test_helper'
|
||||
|
||||
module ActiveModel
|
||||
class Serializer
|
||||
class Adapter
|
||||
class JsonApi
|
||||
class Collection < Minitest::Test
|
||||
def setup
|
||||
@first_post = Post.new(id: 1, title: 'Hello!!', body: 'Hello, world!!')
|
||||
@second_post = Post.new(id: 2, title: 'New Post', body: 'Body')
|
||||
@first_post.comments = []
|
||||
@second_post.comments = []
|
||||
|
||||
@serializer = ArraySerializer.new([@first_post, @second_post])
|
||||
@adapter = ActiveModel::Serializer::Adapter::JsonApi.new(@serializer)
|
||||
end
|
||||
|
||||
def test_include_multiple_posts
|
||||
assert_equal([
|
||||
{title: "Hello!!", body: "Hello, world!!", id: 1, links: {comments: []}},
|
||||
{title: "New Post", body: "Body", id: 2, links: {comments: []}}
|
||||
], @adapter.serializable_hash[:posts])
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -18,7 +18,7 @@ module ActiveModel
|
||||
end
|
||||
|
||||
def test_includes_comment_ids
|
||||
assert_equal([1, 2], @adapter.serializable_hash[:links][:posts])
|
||||
assert_equal([1, 2], @adapter.serializable_hash[:authors][:links][:posts])
|
||||
end
|
||||
|
||||
def test_no_includes_linked_comments
|
||||
|
||||
@@ -18,7 +18,7 @@ module ActiveModel
|
||||
end
|
||||
|
||||
def test_includes_comment_ids
|
||||
assert_equal([1, 2], @adapter.serializable_hash[:links][:comments])
|
||||
assert_equal([1, 2], @adapter.serializable_hash[:posts][:links][:comments])
|
||||
end
|
||||
|
||||
def test_includes_linked_comments
|
||||
|
||||
@@ -5,7 +5,7 @@ module ActiveModel
|
||||
class ArraySerializerTest < Minitest::Test
|
||||
def setup
|
||||
@comment = Comment.new
|
||||
@post= Post.new
|
||||
@post = Post.new
|
||||
@serializer = ArraySerializer.new([@comment, @post])
|
||||
end
|
||||
|
||||
@@ -13,7 +13,7 @@ module ActiveModel
|
||||
assert_respond_to @serializer, :each
|
||||
end
|
||||
|
||||
def test_each_object_should_be_serializer_with_appropriate_serializer
|
||||
def test_each_object_should_be_serialized_with_appropriate_serializer
|
||||
serializers = @serializer.to_a
|
||||
|
||||
assert_kind_of CommentSerializer, serializers.first
|
||||
|
||||
Reference in New Issue
Block a user