ditkrg/active_model_serializers
4
0
Fork 0
mirror of https://github.com/ditkrg/active_model_serializers.git synced 2026-01-24 14:56:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix deserialization of polymorphic relationships (#2200)

Browse Source 
* Classify the relationship type for polymorphic associations
This commit is contained in:
Dennis Stumm 2017-10-08 00:03:38 +02:00 committed by Benjamin Fleischer
parent 715a702f55
commit 4d7c2457d7
4 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -16,6 +16,7 @@ Features:
Fixes: Fixes:
- [#2022](https://github.com/rails-api/active_model_serializers/pull/2022) Mutation of ActiveModelSerializers::Model now changes the attributes. Originally in [#1984](https://github.com/rails-api/active_model_serializers/pull/1984). (@bf4) - [#2022](https://github.com/rails-api/active_model_serializers/pull/2022) Mutation of ActiveModelSerializers::Model now changes the attributes. Originally in [#1984](https://github.com/rails-api/active_model_serializers/pull/1984). (@bf4)
- [#2200](https://github.com/rails-api/active_model_serializers/pull/2200) Fix deserialization of polymorphic relationships. (@dennis95stumm)
Misc: Misc:

2
lib/active_model_serializers/adapter/json_api/deserialization.rb
View File

@ -189,7 +189,7 @@ module ActiveModelSerializers
polymorphic = (options[:polymorphic] || []).include?(assoc_name.to_sym) polymorphic = (options[:polymorphic] || []).include?(assoc_name.to_sym)
if polymorphic if polymorphic
hash["#{prefix_key}_type".to_sym] = assoc_data.present? ? assoc_data['type'] : nil hash["#{prefix_key}_type".to_sym] = assoc_data.present? ? assoc_data['type'].classify : nil
end end
hash hash

2
test/action_controller/json_api/deserialization_test.rb
View File

@ -45,7 +45,7 @@ module ActionController
response = JSON.parse(@response.body) response = JSON.parse(@response.body)
expected = { expected = {
'restriction_for_id' => '67', 'restriction_for_id' => '67',
'restriction_for_type' => 'discounts', 'restriction_for_type' => 'Discount',
'restricted_to_id' => nil, 'restricted_to_id' => nil,
'restricted_to_type' => nil 'restricted_to_type' => nil
} }

2
test/adapter/json_api/parse_test.rb
View File

@ -125,7 +125,7 @@ module ActiveModelSerializers
src: 'http://example.com/images/productivity.png', src: 'http://example.com/images/productivity.png',
author_id: nil, author_id: nil,
photographer_id: '9', photographer_id: '9',
photographer_type: 'people', photographer_type: 'Person',
comment_ids: %w(1 2) comment_ids: %w(1 2)
} }
assert_equal(expected, parsed_hash) assert_equal(expected, parsed_hash)