ditkrg/active_model_serializers
4
0
Fork 0
mirror of https://github.com/ditkrg/active_model_serializers.git synced 2026-01-24 14:56:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

add failing test and suggestion

Browse Source
This commit is contained in:
Mark Havekes 2019-06-04 10:27:02 +02:00
parent 339f99fccc
commit 4b0c230d76
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/active_model_serializers/adapter/json_api/relationship.rb
View File

@ -55,6 +55,7 @@ module ActiveModelSerializers
else else
association.reflection.type.to_s association.reflection.type.to_s
end end
# TODO: probably return nil if association.object is nil?
ResourceIdentifier.for_type_with_id(type, id, serializable_resource_options) ResourceIdentifier.for_type_with_id(type, id, serializable_resource_options)
else else
# TODO(BF): Process relationship without evaluating lazy_association # TODO(BF): Process relationship without evaluating lazy_association

14
test/adapter/json_api/relationship_test.rb
View File

@ -35,6 +35,20 @@ module ActiveModelSerializers
assert_equal(expected, actual) assert_equal(expected, actual)
end end
def test_relationship_with_nil_model_and_belongs_to_id_on_self
ActiveModelSerializers.config.jsonapi_use_foreign_key_on_belongs_to_relationship = true
expected = { data: nil }
model_attributes = { blog: nil }
relationship_name = :blog
model = new_model(model_attributes)
actual = build_serializer_and_serialize_relationship(model, relationship_name) do
belongs_to :blog
end
assert_equal(expected, actual)
end
def test_relationship_with_data_array def test_relationship_with_data_array
expected = { expected = {
data: [ data: [