ditkrg/active_model_serializers
4
0
Fork 0
mirror of https://github.com/ditkrg/active_model_serializers.git synced 2026-01-23 06:16:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #422 from marclove/reduce-serializer-code-complexity

Browse Source 
Reduce duplication; make accessor definition more explicit
This commit is contained in:
Arthur Nogueira Neves 2013-10-25 16:55:01 -07:00
commit 449849516b
1 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/active_model/serializer.rb
View File

@ -69,14 +69,7 @@ end
def attributes(*attrs)
@_attributes.concat attrs
attrs.each do |attr|
unless method_defined?(attr)
define_method attr do
object.read_attribute_for_serialization(attr)
end
end
end
attrs.each{|attr| define_attribute_accessor(attr)}
end
def has_one(*attrs)
@ -93,15 +86,27 @@ end
options = attrs.extract_options!
attrs.each do |attr|
unless method_defined?(attr)
define_method attr do
object.send attr
end
end
define_association_accessor(attr)
@_associations[attr] = klass.new(attr, options)
end
end
def define_accessor_unless_defined(attr, &block)
return if method_defined?(attr)
define_method(attr, &block)
end
def define_attribute_accessor(attr)
define_accessor_unless_defined attr do
object.read_attribute_for_serialization(attr)
end
end
def define_association_accessor(attr)
define_accessor_unless_defined attr do
object.send attr
end
end
end
def initialize(object, options={})