mirror of
https://github.com/ditkrg/active_model_serializers.git
synced 2026-01-24 06:46:50 +00:00
Merge pull request #717 from r-ideas/0-9-stable
fixed issue with rendering Hash which appears in rails 4.2.0.beta4
This commit is contained in:
commit
3baff109eb
@ -7,9 +7,13 @@ rvm:
|
|||||||
- ruby-head
|
- ruby-head
|
||||||
- jruby-19mode
|
- jruby-19mode
|
||||||
- rbx-2
|
- rbx-2
|
||||||
|
- ruby-head
|
||||||
|
|
||||||
sudo: false
|
sudo: false
|
||||||
|
|
||||||
|
install:
|
||||||
|
- bundle install --retry=3
|
||||||
|
|
||||||
env:
|
env:
|
||||||
- "RAILS_VERSION=3.2.17"
|
- "RAILS_VERSION=3.2.17"
|
||||||
- "RAILS_VERSION=4.0.3"
|
- "RAILS_VERSION=4.0.3"
|
||||||
|
|||||||
@ -56,7 +56,7 @@ end
|
|||||||
attr_reader :key_format
|
attr_reader :key_format
|
||||||
|
|
||||||
def serializer_for(resource, options = {})
|
def serializer_for(resource, options = {})
|
||||||
if resource.respond_to?(:each)
|
if resource.respond_to?(:each) && !resource.is_a?(Hash)
|
||||||
if Object.constants.include?(:ArraySerializer)
|
if Object.constants.include?(:ArraySerializer)
|
||||||
::ArraySerializer
|
::ArraySerializer
|
||||||
else
|
else
|
||||||
|
|||||||
@ -19,6 +19,10 @@ module ActionController
|
|||||||
def render_comments
|
def render_comments
|
||||||
render json: [Comment.new(content: 'Comment 1')]
|
render json: [Comment.new(content: 'Comment 1')]
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def render_hash
|
||||||
|
render json: {message: 'not found'}, status: 404
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
tests TestNamespace::MyController
|
tests TestNamespace::MyController
|
||||||
@ -42,6 +46,11 @@ module ActionController
|
|||||||
get :render_comments
|
get :render_comments
|
||||||
assert_serializer CommentSerializer
|
assert_serializer CommentSerializer
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def test_render_hash_regression
|
||||||
|
get :render_hash
|
||||||
|
assert_equal JSON.parse(response.body), {'message' => 'not found'}
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
class OptionNamespacedSerializationTest < ActionController::TestCase
|
class OptionNamespacedSerializationTest < ActionController::TestCase
|
||||||
@ -93,4 +102,4 @@ module ActionController
|
|||||||
end
|
end
|
||||||
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user