ditkrg/active_model_serializers
5
0
Fork 0
mirror of https://github.com/ditkrg/active_model_serializers.git synced 2026-01-25 15:23:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #117 from joliss/computed-attributes

Browse Source 
Make schema not crash on computed attributes & associations
This commit is contained in:
Jo Liss
2012-11-22 08:31:18 -08:00
parent 6b88f1b6ef 538b0c0916
commit 2fc083a1fe
2 changed files with 41 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test/serializer_test.rb
View File

@@ -379,7 +379,7 @@ class SerializerTest < ActiveModel::TestCase
def test_associations_with_as
posts = [
Post.new(:title => 'First Post', :body => 'text'),
Post.new(:title => 'First Post', :body => 'text'),
Post.new(:title => 'Second Post', :body => 'text')
]
user = User.new
@@ -397,15 +397,15 @@ class SerializerTest < ActiveModel::TestCase
{:title => 'Second Post', :body => 'text', :comments => []}
],
:user => {
:first_name => "Jose",
:last_name => "Valim", :ok => true,
:first_name => "Jose",
:last_name => "Valim", :ok => true,
:scope => true
}
}
}, serializer.as_json)
end
def test_implicity_detection_for_association_serializers
def test_implicity_detection_for_association_serializers
implicit_serializer = Class.new(ActiveModel::Serializer) do
root :custom_blog
const_set(:UserSerializer, UserSerializer)
@@ -416,7 +416,7 @@ class SerializerTest < ActiveModel::TestCase
end
posts = [
Post.new(:title => 'First Post', :body => 'text', :comments => []),
Post.new(:title => 'First Post', :body => 'text', :comments => []),
Post.new(:title => 'Second Post', :body => 'text', :comments => [])
]
user = User.new
@@ -434,8 +434,8 @@ class SerializerTest < ActiveModel::TestCase
{:title => 'Second Post', :body => 'text', :comments => []}
],
:user => {
:first_name => "Jose",
:last_name => "Valim", :ok => true,
:first_name => "Jose",
:last_name => "Valim", :ok => true,
:scope => true
}
}
@@ -489,15 +489,21 @@ class SerializerTest < ActiveModel::TestCase
define_method(:model_class) do model end
end
attributes :name, :age
# Computed attributes (not real columns or associations).
def can_edit; end
def drafts; end
attributes :name, :age, :can_edit
has_many :posts, :serializer => Class.new
has_many :drafts, :serializer => Class.new
has_one :parent, :serializer => Class.new
end
assert_equal serializer.schema, {
:attributes => { :name => :string, :age => :integer },
:attributes => { :name => :string, :age => :integer, :can_edit => nil },
:associations => {
:posts => { :has_many => :posts },
:drafts => nil,
:parent => { :belongs_to => :parent }
}
}
@@ -673,7 +679,7 @@ class SerializerTest < ActiveModel::TestCase
expected = serializer_class.new(post).as_json
assert_equal expected, hash_object
end
def test_embed_ids_include_true_with_root
serializer_class = post_serializer
@@ -722,7 +728,7 @@ class SerializerTest < ActiveModel::TestCase
:author => [{ :first_name => "Jose", :last_name => "Valim" }]
}, serializer.as_json)
end
# the point of this test is to illustrate that deeply nested serializers
# still side-load at the root.
def test_embed_with_include_inserts_at_root
@@ -919,7 +925,7 @@ class SerializerTest < ActiveModel::TestCase
actual = attachment_serializer.new(attachment, {}).as_json
assert_equal({
:name => 'logo.png',
:name => 'logo.png',
:url => 'http://example.com/logo.png',
:attachable => {
:type => :email,
@@ -956,7 +962,7 @@ class SerializerTest < ActiveModel::TestCase
actual = attachment_serializer.new(attachment, {}).as_json
assert_equal({
:name => 'logo.png',
:name => 'logo.png',
:url => 'http://example.com/logo.png',
:attachable => {
:type => :email,
@@ -995,7 +1001,7 @@ class SerializerTest < ActiveModel::TestCase
assert_equal({
:attachment => {
:name => 'logo.png',
:name => 'logo.png',
:url => 'http://example.com/logo.png',
:attachable => {
:type => :email,