Adding optional type for attributes

This commit is contained in:
Matt Rogish 2012-12-10 19:58:58 -05:00
parent 6780cd3df5
commit 25c564bd6f
2 changed files with 12 additions and 6 deletions

View File

@ -73,7 +73,9 @@ module ActiveModel
end
def attribute(attr, options={})
self._attributes = _attributes.merge(attr => options[:key] || attr.to_s.gsub(/\?$/, '').to_sym)
self._attributes = _attributes.merge(attr.is_a?(Hash) ? attr : {attr => options[:key] || attr.to_s.gsub(/\?$/, '').to_sym})
attr = attr.keys[0] if attr.is_a? Hash
unless method_defined?(attr)
define_method attr do
@ -175,8 +177,12 @@ module ActiveModel
attrs[key] = column.type
else
# Computed attribute (method on serializer or model). We cannot
# infer the type, so we put nil.
attrs[key] = nil
# infer the type, so we put nil, unless specified in the attribute declaration
if name != key
attrs[name] = key
else
attrs[key] = nil
end
end
end

View File

@ -493,14 +493,14 @@ class SerializerTest < ActiveModel::TestCase
def can_edit; end
def drafts; end
attributes :name, :age, :can_edit
attributes :name, :age, :can_edit => :boolean
has_many :posts, :serializer => Class.new
has_many :drafts, :serializer => Class.new
has_one :parent, :serializer => Class.new
end
assert_equal serializer.schema, {
:attributes => { :name => :string, :age => :integer, :can_edit => nil },
:attributes => { :name => :string, :age => :integer, :can_edit => :boolean },
:associations => {
:posts => { :has_many => :posts },
:drafts => nil,
@ -1004,7 +1004,7 @@ class SerializerTest < ActiveModel::TestCase
:name => 'logo.png',
:url => 'http://example.com/logo.png',
:attachable => {
:type => :email,
:type => :email,
:id => 1
}},
:emails => [{