mirror of
https://github.com/ditkrg/active_model_serializers.git
synced 2026-01-23 06:16:50 +00:00
Fix options merge order in each_association
Custom association serializers were getting clobbered when using an each serializer.
This commit is contained in:
parent
9058d5fce7
commit
03372ea61d
@ -187,7 +187,7 @@ module ActiveModel
|
|||||||
|
|
||||||
serializer = serializer_class.new(
|
serializer = serializer_class.new(
|
||||||
association_value,
|
association_value,
|
||||||
serializer_from_options(association_options).merge(options)
|
options.merge(serializer_from_options(association_options))
|
||||||
) if serializer_class
|
) if serializer_class
|
||||||
|
|
||||||
if block_given?
|
if block_given?
|
||||||
|
|||||||
@ -37,6 +37,24 @@ module ActionController
|
|||||||
render json: array,
|
render json: array,
|
||||||
each_serializer: ProfilePreviewSerializer
|
each_serializer: ProfilePreviewSerializer
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def render_array_using_explicit_serializer_and_custom_serializers
|
||||||
|
@post = Post.new(title: 'New Post', body: 'Body')
|
||||||
|
@author = Author.new(name: 'Jane Blogger')
|
||||||
|
@author.posts = [@post]
|
||||||
|
@post.author = @author
|
||||||
|
@first_comment = Comment.new(id: 1, body: 'ZOMG A COMMENT')
|
||||||
|
@second_comment = Comment.new(id: 2, body: 'ZOMG ANOTHER COMMENT')
|
||||||
|
@post.comments = [@first_comment, @second_comment]
|
||||||
|
@first_comment.post = @post
|
||||||
|
@first_comment.author = nil
|
||||||
|
@second_comment.post = @post
|
||||||
|
@second_comment.author = nil
|
||||||
|
@blog = Blog.new(id: 23, name: 'AMS Blog')
|
||||||
|
@post.blog = @blog
|
||||||
|
|
||||||
|
render json: [@post], each_serializer: PostPreviewSerializer
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
tests MyController
|
tests MyController
|
||||||
@ -73,6 +91,20 @@ module ActionController
|
|||||||
assert_equal expected.to_json, @response.body
|
assert_equal expected.to_json, @response.body
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def test_render_array_using_explicit_serializer_and_custom_serializers
|
||||||
|
get :render_array_using_explicit_serializer_and_custom_serializers
|
||||||
|
|
||||||
|
expected = [
|
||||||
|
{ "title" => "New Post",
|
||||||
|
"body" => "Body",
|
||||||
|
"id" => assigns(:post).id,
|
||||||
|
"comments" => [{"id" => 1}, {"id" => 2}],
|
||||||
|
"author" => { "id" => assigns(:author).id }
|
||||||
|
}
|
||||||
|
]
|
||||||
|
|
||||||
|
assert_equal expected.to_json, @response.body
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user