diff --git a/.travis.yml b/.travis.yml index befddbc6..2cc4065b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,10 +33,18 @@ env: matrix: exclude: + - rvm: 1.9.3 + env: RAILS_VERSION=master + - rvm: 2.0.0 + env: RAILS_VERSION=master - rvm: 2.1 env: RAILS_VERSION=master - rvm: jruby-9.1.5.0 env: RAILS_VERSION=master + - rvm: 1.9.3 + env: RAILS_VERSION=5.0 + - rvm: 2.0.0 + env: RAILS_VERSION=5.0 - rvm: 2.1 env: RAILS_VERSION=5.0 - rvm: jruby-9.1.5.0 diff --git a/Gemfile b/Gemfile index e55e2bfe..d5d669a1 100644 --- a/Gemfile +++ b/Gemfile @@ -6,11 +6,14 @@ version = ENV["RAILS_VERSION"] || "4.2" if version == 'master' gem 'rack', github: 'rack/rack' + gem 'arel', github: 'rails/arel' + gem 'rails', github: 'rails/rails' git 'https://github.com/rails/rails.git' do gem 'railties' gem 'activesupport' gem 'activemodel' gem 'actionpack' + gem 'activerecord', group: :test # Rails 5 gem 'actionview' end @@ -18,10 +21,12 @@ if version == 'master' gem 'rails-controller-testing', github: 'rails/rails-controller-testing' else gem_version = "~> #{version}.0" + gem 'rails', gem_version gem 'railties', gem_version gem 'activesupport', gem_version gem 'activemodel', gem_version gem 'actionpack', gem_version + gem 'activerecord', gem_version, group: :test end if RUBY_VERSION < '2' @@ -36,14 +41,14 @@ end @windows_platforms = [:mswin, :mingw, :x64_mingw] # Windows does not include zoneinfo files, so bundle the tzinfo-data gem -gem 'tzinfo-data', platforms: (@windows_platforms + [:jruby]) +tzinfo_platforms = @windows_platforms +tzinfo_platforms += [:jruby] if version >= '4.1' +gem 'tzinfo-data', platforms: tzinfo_platforms group :test do - gem 'activerecord' gem 'sqlite3', platform: (@windows_platforms + [:ruby]) gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby - gem 'codeclimate-test-reporter', require: false gem 'simplecov', '~> 0.10', require: false, group: :development end diff --git a/lib/active_model/serializer.rb b/lib/active_model/serializer.rb index 9b3d6e6c..82693873 100644 --- a/lib/active_model/serializer.rb +++ b/lib/active_model/serializer.rb @@ -203,7 +203,7 @@ end if included_associations.include? name association_serializer = build_serializer(association) # we must do this always because even if the current association is not - # embeded in root, it might have its own associations that are embeded in root + # embedded in root, it might have its own associations that are embedded in root hash.merge!(association_serializer.embedded_in_root_associations) do |key, oldval, newval| if oldval.respond_to?(:to_ary) [oldval, newval].flatten.uniq diff --git a/test/fixtures/poro.rb b/test/fixtures/poro.rb index e9d36fc0..d122f097 100644 --- a/test/fixtures/poro.rb +++ b/test/fixtures/poro.rb @@ -49,7 +49,7 @@ end class SpecialPost < Post def special_comment - @speical_comment ||= Comment.new(content: 'special') + @special_comment ||= Comment.new(content: 'special') end end